Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request : open push button and closed push button #128

Closed
dilawar opened this issue Nov 19, 2018 · 9 comments
Closed

request : open push button and closed push button #128

dilawar opened this issue Nov 19, 2018 · 9 comments
Assignees

Comments

@dilawar
Copy link

@dilawar dilawar commented Nov 19, 2018

Hi, Great library.

I guess currently there is only one push button style. I needed push button in both open and closed configuration. I was able to create them by changing bipoles/pushbutton/height parameter.

I guess having every switch in open and closed styles would be great.

@Rmano Rmano self-assigned this Feb 20, 2019
@Rmano
Copy link
Collaborator

@Rmano Rmano commented Feb 20, 2019

Like this?

image

@Rmano
Copy link
Collaborator

@Rmano Rmano commented Feb 20, 2019

Notice that I did the "stems" differently on purpose so that labels are naturally aligned on horizontal lines of switches.
I'll merge and close, please re-open if needed.

@Rmano Rmano closed this in #156 Feb 20, 2019
Rmano added a commit that referenced this issue Feb 20, 2019
Add the normally closed push-button; fixes #128
@septatrix
Copy link

@septatrix septatrix commented Nov 22, 2020

I like these however I think it would be nice to have a closed variant of the normally open push button and vice versa. The difference would be that for the closed normally open button the contact would be at the top of both terminal dots and for the opened normally closed button the gap would be below the terminal circles.

@Rmano
Copy link
Collaborator

@Rmano Rmano commented Nov 22, 2020

Hmm, that's a good idea...

Should the stem maintain the same length or should the upper point stay in the same position? Not sure...

image

@septatrix
Copy link

@septatrix septatrix commented Nov 22, 2020

For me it would be most important that the text/labels remain at the same height. As their position depends on the anchors I think it would be best to make the stem longer and maintain the same anchor position. Decoupling the anchor from the stam seems like a bad idea (to me at least).

@Rmano
Copy link
Collaborator

@Rmano Rmano commented Nov 23, 2020

It is possible to have both things (I can fake the size of the stem); I mean, it is possible to have the stem "going down" and maintain the label position. Or at least I think ;-)

@septatrix
Copy link

@septatrix septatrix commented Nov 23, 2020

I just realized that these buttons are path styles and not nodes so I think they do not even have anchors accessible from the outside. So if they do not allow one to put something at the stem manually I think it would be nice to keep the stem size and move everything down.

Otherwise I would have imagined people attaching things (e.g. lines) to the steam which would either shift or get disconnected when they are moved down but as this does not even seem possible I am in favour of keeping the stem length the same.

@Rmano
Copy link
Collaborator

@Rmano Rmano commented Nov 23, 2020

I just realized that these buttons are path styles and not nodes so I think they do not even have anchors accessible from the outside. So if they do not allow one to put something at the stem manually I think it would be nice to keep the stem size and move everything down.

You can access anchors! Just name the path object: to[R, name=myr] and then you can refer to the anchors (myr.north west) etc etc. And the other way around, you can use any path style as a node: node[resistorshape](){} (the shape name is listed in the manual).

@septatrix
Copy link

@septatrix septatrix commented Nov 23, 2020

Oh that is great to know. Than I am personally in favour of having the upper end of the stem stay in the same position.

@Rmano Rmano reopened this Nov 29, 2020
Rmano added a commit to Rmano/circuitikz that referenced this issue Nov 29, 2020
@Rmano Rmano linked a pull request that will close this issue Nov 29, 2020
@Rmano Rmano closed this in #461 Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants