Rewrite path formation #418
Merged
Conversation
|
I think I will merge this if there are no comments. Seems correct, and compiles the manual just fine. Moreover, if I don't merge and release nobody will test it... ;-) |
This basically remove the patches introduced for issue circuitikz#58 and circuitikz#76 Reverts these: circuitikz@6efc2ee circuitikz@352d2bf Then, it carefully builds the anchors without moving the start of the path, and then join it with a leading --.
Notice that it worked because of (basically) a circuitikz bug. The path was drawn up and down several times, so that the default pos=0.5 was putting the labels to the end...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This basically removes the patches introduced for issue #58 and #76
Reverts these:
Then, it carefully builds the anchors without moving the start of the path, and then join it with a leading
--Fixes #417
Fixes #76
Fixes #58
The text was updated successfully, but these errors were encountered: