Select pins in dipchip #550
Conversation
|
It seems that it is impossible to add a commit here (a pity, it would be nice to have mixed author PRs...) Will make Travis happy (I think) and also all the users of TeXLive2019 that use the "last release" from the GitHub page (I know there is quite a number). |
|
There is still no formal test here whether the feature really works or not. All we do know is that there is no real error for the current version of the manual. So what's still missing here?
I'm pretty sure the list parsing macros are stable (well, as stable as documented in the sources). Edge cases that will result in a low level TeX error are:
Unsupported input/stuff:
Everything else should work. I'm entirely unsure on the PGF side of this PR, as I have not much experience with low level PGF, so I'm quite unsure whether everything works. Some quick small tests indicated only expected behaviour, but that doesn't mean I'm confident with this stuff. |
|
I think that it looks wonderful. I checked with a few extreme cases (empty list, out-of-range pins) and it works. Do you want to add the doc or I do that? Also, I like the names ( |
|
|
|
Before I forget. I saw there is some change-log in place. I haven't touched that :) |
|
Ah yes, the file is the Changelog.md in the top dir, in markdown format. Normally I add attribution there also, look at the previous entries. Do not forget to add some attribution in the code also if you like! |
|
Hi @Skillmon --- I was thinking that I'll probably squash and merge this, to avoid the "red cross" points in history that can hinder future bisections. I will wait till you add changelog and attribution (unless you tell me you don't want those). |
|
@Rmano Added some attribution notices. If the plan is to also provide this for Should be ready to merge now. |
Ok (I normally add the changelog line and then I edit it with the next commit, but it's more or less the same --- I do not think that inter-releases things have much visibility anyhow) |
|
I will start to work on porting this to |
|
Yes, sure you might rename it. In the end it should be readable to the maintainers, not to an occasional contributor :) If you have any other questions regarding the code, feel free to ask. |
This PR will add the key
multipoles/draw only pinsthat takes a comma separated list of numbers that specify which pins will be drawn indipchip. Thepinanchors will be set accordingly. The key takes a special valueallthat means that every pin is drawn.The text was updated successfully, but these errors were encountered: