Please sign in to comment.
Allow to run multiple io.process.Process objects simultaneously
Currently, Process incorrectly handles stdout/stderr channels which rely on global state: - static methods used to handle read/close events are instantiated on module import. Thus, they are being mocked by addHandler() which sets .channel to them. Starting a new process causes resetting that field on the global method objects, thus all processes will receive output from the last started process. To mitigate this, static methods are replaced with closure-like lambdas. - Process incorrectly raises stopped() event to close stdout/stderr. This event, however, is used to signal Manager's death. Thus, when process is completed, all sockets/pipes in the entire program are closed. This is why stopped() event has to be replaced with process-specific terminated() event and we need explicitly send close() to all process pipes.
- Loading branch information
Showing with 56 additions and 28 deletions.