Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow to run multiple io.process.Process objects simultaneously #157
Currently, Process incorrectly handles stdout/stderr channels which rely on
Currently, Process incorrectly handles stdout/stderr channels which rely on global state: - static methods used to handle read/close events are instantiated on module import. Thus, they are being mocked by addHandler() which sets .channel to them. Starting a new process causes resetting that field on the global method objects, thus all processes will receive output from the last started process. To mitigate this, static methods are replaced with closure-like lambdas. - Process incorrectly raises stopped() event to close stdout/stderr. This event, however, is used to signal Manager's death. Thus, when process is completed, all sockets/pipes in the entire program are closed. This is why stopped() event has to be replaced with process-specific terminated() event and we need explicitly send close() to all process pipes.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.