Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a complete event bug (#123) #172

Merged
merged 1 commit into from Jul 6, 2016

Conversation

Projects
None yet
3 participants
@keli
Copy link
Contributor

keli commented Jul 5, 2016

I think I found the bug. The code I changed were comparing the thread's ident with a thread object itself (or None), which always end up with False so the code inside the if block was never executed.

This commit appears to have fixed the tests users reported.

Fixes #123

@spaceone

This comment has been minimized.

Copy link
Contributor

spaceone commented Jul 5, 2016

very nice!

@prologic

This comment has been minimized.

Copy link
Member

prologic commented Jul 6, 2016

Nice one!

@prologic prologic merged commit 25e78c0 into circuits:master Jul 6, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
code-review/pullapprove Approval required by prologic
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.