Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests]: Improve test reliability on OS X / BSD #176

Merged
merged 5 commits into from Jan 16, 2017

Conversation

@prologic
Copy link
Member

@prologic prologic commented Jul 24, 2016

Fixes #174

@coveralls
Copy link

@coveralls coveralls commented Jul 24, 2016

Coverage Status

Coverage increased (+25.9%) to 100.0% when pulling 9033b6d on improve_test_reliability#174 into 930ca39 on master.

@prologic prologic changed the title [tests]: Fix test_tcp_lookup failure by using an invalid FQDN [tests]: Improve test reliability on OS X / BSD Jul 26, 2016


from circuits import ipc, Component, Event


if pytest.PLATFORM == "win32":
pytest.skip("Unsupported Platform")
Copy link
Contributor

@apollo13 apollo13 Jan 15, 2017

this needs to be pytestmark = pytest.mark.skip("Unsupported Platform") on newer pytest versions.

Copy link
Member Author

@prologic prologic Jan 16, 2017

Thanks!

@@ -15,6 +15,10 @@
from circuits.node import Node


if PLATFORM == 'win32':
skip('Broken on Windows')
Copy link
Contributor

@apollo13 apollo13 Jan 15, 2017

Same as above.

Copy link
Member Author

@prologic prologic Jan 16, 2017

Okay

@prologic prologic force-pushed the improve_test_reliability#174 branch from 4795828 to cba8d08 Jan 16, 2017
@prologic prologic force-pushed the improve_test_reliability#174 branch from cba8d08 to 9033b6d Jan 16, 2017
@prologic prologic merged commit a63e641 into master Jan 16, 2017
0 of 3 checks passed
@spaceone spaceone deleted the improve_test_reliability#174 branch Jan 31, 2017
spaceone added a commit to spaceone/circuits that referenced this issue Feb 12, 2017
* [tests]: Fix test_tcp_lookup failure by using an invalid FQDN

* [tests]: Fixed test_auto_reconnect node test reliability

* [tests]: Improve bridge and node tests for OS X

* [tests]: Increase general wait/watcher timeout to 30s

* [tests]: Fix tests/node/test_server.py::test_auto_reconnect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants