Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed early test failure on new pytest version. #188

Merged
merged 2 commits into from Jan 15, 2017

Conversation

Projects
None yet
3 participants
@apollo13
Copy link
Contributor

apollo13 commented Jan 14, 2017

See pytest-dev/pytest#607 for details.

@prologic prologic requested a review from spaceone Jan 14, 2017

@apollo13 apollo13 force-pushed the apollo13:patch-1 branch from b4c3862 to cda1fb3 Jan 15, 2017

@apollo13 apollo13 changed the title Update packages on install to see early failures from new version. Fixed early test failure on new pytest version. Jan 15, 2017

@apollo13 apollo13 force-pushed the apollo13:patch-1 branch from cda1fb3 to 070c19f Jan 15, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 15, 2017

Coverage Status

Coverage decreased (-1.8%) to 76.671% when pulling cda1fb3 on apollo13:patch-1 into d6aeb45 on circuits:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 15, 2017

Coverage Status

Coverage decreased (-5.7%) to 72.804% when pulling 3079326 on apollo13:patch-1 into d6aeb45 on circuits:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 15, 2017

Coverage Status

Coverage decreased (-5.7%) to 72.804% when pulling 3079326 on apollo13:patch-1 into d6aeb45 on circuits:master.

@apollo13

This comment has been minimized.

Copy link
Contributor Author

apollo13 commented Jan 15, 2017

Should be merge-ready -- no idea why coveralls thinks the coverage decreased ^^

This was referenced Jan 15, 2017

@prologic prologic merged commit cd17094 into circuits:master Jan 15, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
code-review/pullapprove Approval required by prologic
Details

@apollo13 apollo13 deleted the apollo13:patch-1 branch Jan 15, 2017

spaceone added a commit to spaceone/circuits that referenced this pull request Feb 12, 2017

Fixed early test failure on new pytest version. (circuits#188)
* Fixed early test failure on new pytest version.

See pytest-dev/pytest#607 for details.

* Fixed pytest skips on python 2.6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.