Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to set additional socket options #215

Merged
merged 1 commit into from Jan 29, 2017

Conversation

Projects
None yet
4 participants
@spaceone
Copy link
Contributor

spaceone commented Jan 24, 2017

from circuits.net.sockets import TCPServer
from socket import SOL_SOCKET, SO_REUSEPORT
s = TCPServer(('0.0.0.0', 8090), socket_options=[(SOL_SOCKET, SO_REUSEPORT, 1)])
assert s._sock.getsockopt(SOL_SOCKET, SO_REUSEPORT) == 1

Fixes #102

@spaceone spaceone force-pushed the socket_options branch 2 times, most recently from 4882b2a to 74a56a7 Jan 25, 2017

@apollo13
Copy link
Contributor

apollo13 left a comment

LGTM :shipit:

@prologic

This comment has been minimized.

Copy link
Member

prologic commented Jan 29, 2017

Rebase?

Add support to set additional socket options
from circuits.net.sockets import TCPServer
from socket import SOL_SOCKET, SO_REUSEPORT
s = TCPServer(('0.0.0.0', 8090), socket_options=[(SOL_SOCKET, SO_REUSEPORT, 1)])
assert s._sock.getsockopt(SOL_SOCKET, SO_REUSEPORT) == 1

@spaceone spaceone force-pushed the socket_options branch from 74a56a7 to b478492 Jan 29, 2017

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 29, 2017

Current coverage is 77.17% (diff: 97.36%)

Merging #215 into master will decrease coverage by 0.79%

@@             master       #215   diff @@
==========================================
  Files            80         80          
  Lines          6657       6663     +6   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           5190       5142    -48   
- Misses         1467       1521    +54   
  Partials          0          0          

Powered by Codecov. Last update ebc2e4a...b478492

@spaceone spaceone merged commit be3405a into master Jan 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@prologic prologic removed the in progress label Jan 29, 2017

@spaceone spaceone deleted the socket_options branch Jan 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.