New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make __str__ compatible with py2 (six-decorator) #233

Merged
merged 2 commits into from Jul 17, 2017

Conversation

Projects
None yet
4 participants
@bloodywing
Contributor

bloodywing commented Jul 17, 2017

This the one with decorator.
Also see: #232 and #229

A cleaner approve to fix str in Value for Python2. This is the way as six suggests it.

Fixes #229

make __str__ compatible with py2 (six-decorator)
This the one with decorator.
Also see: #232 and #229
Update values.py
PEP8 clean up. One blank line was missing.
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jul 17, 2017

Codecov Report

Merging #233 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
+ Coverage    77.2%   77.26%   +0.06%     
==========================================
  Files          80       80              
  Lines        6716     6717       +1     
==========================================
+ Hits         5185     5190       +5     
+ Misses       1531     1527       -4
Impacted Files Coverage Δ
circuits/core/values.py 87.83% <100%> (+0.16%) ⬆️
circuits/net/sockets.py 82.37% <0%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd519fa...3909f20. Read the comment docs.

codecov-io commented Jul 17, 2017

Codecov Report

Merging #233 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
+ Coverage    77.2%   77.26%   +0.06%     
==========================================
  Files          80       80              
  Lines        6716     6717       +1     
==========================================
+ Hits         5185     5190       +5     
+ Misses       1531     1527       -4
Impacted Files Coverage Δ
circuits/core/values.py 87.83% <100%> (+0.16%) ⬆️
circuits/net/sockets.py 82.37% <0%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd519fa...3909f20. Read the comment docs.

@spaceone spaceone merged commit 1327b29 into circuits:master Jul 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment