New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix IRC color stripping #245

Merged
merged 1 commit into from Nov 22, 2018

Conversation

Projects
None yet
2 participants
@spaceone
Copy link
Contributor

spaceone commented Sep 11, 2018

the circuits.protocols.utils.irc.strip(string, color=True) function doesn't properly strip color sequences but only bold text. Now it strips colors, italics, etc as well as reset markers.

@spaceone spaceone force-pushed the spaceone:irc_color_stripping branch from 9735139 to 4bdd38e Sep 11, 2018

@spaceone spaceone requested a review from prologic Sep 11, 2018

@spaceone spaceone force-pushed the spaceone:irc_color_stripping branch from 4bdd38e to 17d2140 Sep 15, 2018

@spaceone spaceone force-pushed the spaceone:irc_color_stripping branch from 17d2140 to c1eaff7 Sep 24, 2018

@spaceone

This comment has been minimized.

Copy link
Contributor

spaceone commented Nov 21, 2018

Let's get this merged please!

@prologic

This comment has been minimized.

Copy link
Member

prologic commented Nov 21, 2018

@prologic prologic merged commit 1a7e74b into circuits:master Nov 22, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment