Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

papa_endpoint ipc socket is ignored, tcp is created #1066

Closed
meitham opened this issue Apr 5, 2018 · 4 comments
Closed

papa_endpoint ipc socket is ignored, tcp is created #1066

meitham opened this issue Apr 5, 2018 · 4 comments

Comments

@meitham
Copy link

meitham commented Apr 5, 2018

I have three different ipc sockets defined in circus, such as:

pubsub_endpoint = ipc:///path/to//circus/sockets/circus-pubsub.sock
stats_endpoint = ipc:///path/to//circus/sockets/circus-stats.sock
papa_endpoint = ipc:///path/to//circus/sockets/circus-papa.sock

The pubsub and stats sockets are created correctly, but circus seems to ignore my papa socket and bind itself to the default 20202 socket.

@k4nar
Copy link
Contributor

k4nar commented Apr 6, 2018

I think the error is here:

config['papa_endpoint'] = dget('circus', 'fqdn_prefix', None, str)

It should be papa_endpoint instead of fqdn_prefix.

@meitham
Copy link
Author

meitham commented Apr 6, 2018

Thanks for taking a look, and well spotted!
I have tested this and there must be something else going on too, as that fix alone didn't work, and the socket continues to be 20202. I'm looking at papa_process_proxy.py but I can't see anything obviously wrong yet.

@meitham
Copy link
Author

meitham commented Apr 6, 2018

I found it! papa_endpoint wasn't being passed to the Arbiter on initialization. I should be able to send a PR later today.

@meitham
Copy link
Author

meitham commented Apr 6, 2018

PR: #1067

@meitham meitham closed this as completed Apr 6, 2018
k4nar added a commit that referenced this issue Apr 6, 2018
bugfix: papa_endpoint ipc socket is ignored, tcp is created issue #1066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants