Remove an unnecessary dev dependency #169
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsf9k
added
the
improvement
github-actions
bot
added
dependencies
jsf9k
removed
the
test
github-actions
bot
added
the
test
jsf9k
force-pushed
the
improvement/remove-unnecessary-dev-dependency
branch
from
4507bbb to
5a3043d
Compare
types-setuptools is not necessary here since we are not interfacing with setuptools directly. Also update the accompanying comment to refer to pyproject.toml instead of setup.py.
jsf9k
force-pushed
the
improvement/remove-unnecessary-dev-dependency
branch
from
5a3043d to
335258c
Compare
dav3r
approved these changes
Dec 1, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes the unnecessary types-setuptools development dependency from the project, as the code does not directly interface with setuptools.
- Removed
types-setuptoolsfrom dev dependencies inpyproject.toml - Removed
types-setuptoolsfrom mypy pre-commit hook configuration - Updated comment to reference
pyproject.tomlinstead of the non-existentsetup.py
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Removed types-setuptools from the dev optional dependencies list |
| .pre-commit-config.yaml | Removed types-setuptools from mypy hook dependencies and corrected comment to reference pyproject.toml instead of setup.py |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request removes the
types-setuptoolslibrary as adevdependency.💭 Motivation and context
types-setuptoolsis not necessary here since we are not interfacing withsetuptoolsdirectly.🧪 Testing
All automated tests pass.
✅ Pre-approval checklist