Minitest: router_bgp fixes for n6k #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `rd` needs `nv overlay evpn` to expose cli * nexus does not support nsr * added a common method to check for attrs that are excluded from cmd_ref * `cmd_ref.lookup` returns type `UnsupportedCmdRef`
mikewiebe
reviewed
Feb 6, 2019
| Gem::Version.new(lim) < Gem::Version.new(ver) | ||
| end | ||
|
|
||
| def skip_if_UnsupportedCmdRef(feature_name, attribute_name) # rubocop:disable Style/MethodName |
mikewiebe
reviewed
Feb 6, 2019
| end | ||
|
|
||
| def test_nsr | ||
| skip_if_UnsupportedCmdRef('bgp', 'nsr') |
Contributor
There was a problem hiding this comment.
Looks like the nsr stuff was added by the XR team when they were still doing puppet. I see that NSR is supported for OSPFv2 on Nexus but there is no mention of BGP. Did you find documentation that states it's not supported for BGP or is it the absence of the CLI?
Contributor
Author
There was a problem hiding this comment.
Neither. Our yaml excludes it so I added this check to obey the yaml. (sushirol exluded it from nexus when he added the attr)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdneedsnv overlay evpnto expose clicmd_ref.lookupreturns typeUnsupportedCmdRef