vxlan minitest fixes #621
Merged
vxlan minitest fixes #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* n6k has feature-set fabricpath dependency * Added getter/setter to feature.rb
mikewiebe
reviewed
Feb 7, 2019
| @@pre_clean_needed = false # rubocop:disable Style/ClassVars | ||
| rescue RuntimeError => e | ||
| # Skip locally to shortcut the dependencies above for the next test | ||
| @@feature_unsupported = hardware_supports_feature?(e.message, status_only: true) # rubocop:disable Style/ClassVars |
Contributor
There was a problem hiding this comment.
Ok, so if I am reading this correctly, the first test will still go through the dependency list but then skips will go quickly after that.
mikewiebe
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified
hardware_supports_feature?to just return a status instead of doing only a skip or flunk. This allows the callers to cache the status and act on it themselves. In the vxlan tests thesetuptakes ~12s (per testcase) to process dependencies before it fails so this change allows us to short-circuit dependency loading and shave a few minutes off of each test overall.Tested on n6k, n7k, n9k, n3k