Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve extra ex_data parameter of server callback functions #5

Closed
DDvO opened this issue Apr 23, 2014 · 3 comments

Comments

@DDvO
Copy link

@DDvO DDvO commented Apr 23, 2014

I came across the last parameter 'ex_data' of the server callback functions:

int (*est_enroll_pkcs10_cb)(unsigned char *pkcs10, int p10_len, 
                        unsigned char **pkcs7, int *cert_len,
            char *user_id, X509 *peer_cert,
            void *ex_data);
int (*est_reenroll_pkcs10_cb)(unsigned char *pkcs10, int p10_len, 
                          unsigned char **pkcs7, int *cert_len,
              char *user_id, X509 *peer_cert,
              void *ex_data);
unsigned char *(*est_get_csr_cb)(int *csr_len, void *ex_data);
int (*est_http_auth_cb)(struct est_ctx *ctx, EST_HTTP_AUTH_HDR *ah, 
                    X509 *peer_cert, void *ex_data);

partially documented at the est_set_ex_data() function declaration in est.c .

I suggest completing its documentation in est_server.c and est_locl.h and removing its test use in estserver.c, as done tentatively in the diff I'm going to provide,

@jfigus

This comment has been minimized.

Copy link
Contributor

@jfigus jfigus commented Apr 23, 2014

Rather than providing a diff, the suggested work-flow for contributing code is:

  1. Fork the branch in github
  2. Make the changes to your local fork
  3. Submit a pull request to contribute your changes back to the libest branch that you forked
@jfigus

This comment has been minimized.

Copy link
Contributor

@jfigus jfigus commented Jun 5, 2015

Closing issue, still have not see a pull request with the proposed fix.

@jfigus jfigus closed this Jun 5, 2015
@DDvO

This comment has been minimized.

Copy link
Author

@DDvO DDvO commented Jun 8, 2015

The suggested improvements have been included, among many others, in the set of changes provided on March 20th.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.