Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update locales-zh-CN.xml #192

Merged
merged 2 commits into from Apr 16, 2019

Conversation

Projects
None yet
5 participants
@stultulo
Copy link
Contributor

commented Apr 8, 2019

  1. The "于" is used to instead of the "於" in Simplified Chinese.
  2. Added a period after the "等".
Update locales-zh-CN.xml
1. The "于" is used to instead of the "於" in Simplified Chinese.
2. Added a period after the "等".
@csl-bot

This comment has been minimized.

Copy link

commented Apr 8, 2019

Awesome! You just created a pull request to the Citation Styles Language locales repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your locale file validates.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your locale file to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

commented Apr 8, 2019

Yay! Your pull request passed all our automated tests. We'll take a look soon.

@rmzelle

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

@sati-bodhi, could you take a look to check whether these changes look correct to you?

@redleafnew

This comment has been minimized.

Copy link

commented Apr 15, 2019

line 28: 见於 should be 见于
line 33: 载於 should be 载于
line 38: 见引於 should be 见引于
line 53: 发表於 should be 发表于。

i.e. all 於 should be replaced with 于。

@redleafnew

This comment has been minimized.

Copy link

commented Apr 15, 2019

Added a period after the "等". is not necessary.

@sati-bodhi

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

@rmzelle,
Yes, the changes indicated by @redleafnew and @stultulo are correct.

@csl-bot

This comment has been minimized.

Copy link

commented Apr 15, 2019

Yay! Your pull request passed all our automated tests. We'll take a look soon.

@rmzelle rmzelle merged commit 761acba into citation-style-language:master Apr 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

Added a period after the "等". is not necessary.

Thanks all! I removed the period after "等" per @redleafnew's suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.