Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reviewed-title to american-chemical-society-* and reviews-of-modern-physics-with-titles #1521

Closed

Conversation

serpodrick
Copy link
Contributor

Hi

This pull request adds reviewed-title to the american-chemical-society-* and reviews-of-modern-physics-with-titles styles.

Both style guides are entirely silent about about these kinds of publications.

(As an aside, the review and review-book types are confusing. I haven't figured out what review-book is supposed to mean!)

@adam3smith
Copy link
Member

Not sure about this -- as it is, this would seem to add confusion if anything: It may look like the review title is part of the title or (in absence of a title) actually the title of the work. How are you envisioning this being used?

@adam3smith
Copy link
Member

(Travis fails because you're misspelling delimiter, btw.)

@serpodrick
Copy link
Contributor Author

I'm trying to add the reviewed-title after the title like council-of-science-editors does. The CSE style uses the type (review or review-book) to decide whether or not to display reviewed. I was trying to avoid that since if reviewed-title has a value, it's a review. (<ost of the things I'm trying to create citations for are actually journal articles.) Adding it to the title macro was easier than adding a review macro.

If following the model in council-of-science-editors would be accepted, I can submit a new pull request. (I only use american-chemical-society-with-titles version of ACS and forgot to test the others, sorry!)

@adam3smith
Copy link
Member

What I'm wondering isn't how the style is going to tell this is a review (that makes sense) but how the reader would be able to tell from a citation that it is.

@serpodrick serpodrick closed this Apr 20, 2015
@serpodrick
Copy link
Contributor Author

I agree. I'll use a non-CSL solution for what I'm trying to accomplish.

@serpodrick serpodrick deleted the reviewed-title branch April 22, 2015 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants