Creating author-date style for Archéologie médiévale #858

Merged
merged 6 commits into from Feb 27, 2014

Projects

None yet

2 participants

Contributor

No description provided.

Contributor

Well, I can't see why there is this incompatibility between class=note and category=author-date.

Owner

just by convention. As per the specs, when a citation gets placed in a footnote/endnote cs:category should be note http://citationstyles.org/downloads/specification.html#info regardless of what information is in the note.

Owner

yeah, so this needs <category citation-format="note"/>

Contributor

Ah, ok
Thanks for the answer

Le 27 févr. 2014 à 19:49, Sebastian Karcher notifications@github.com a écrit :

just by convention. As per the specs, when a citation gets placed in a footnote/endnote cs:category should be note http://citationstyles.org/downloads/specification.html#info regardless of what information is in the note.


Reply to this email directly or view it on GitHub.

@adam3smith adam3smith and 1 other commented on an outdated diff Feb 27, 2014
archeologie-medievale.csl
+ </date>
+ </group>
+ </macro>
+ <macro name="editor-text">
+ <names variable="editor">
+ <name name-as-sort-order="all" font-variant="small-caps" sort-separator=" " initialize-with="." delimiter-precedes-last="never" and="text" delimiter=", "/>
+ </names>
+ <text value=" (éd.), "/>
+ <text macro="publisher" suffix=", "/>
+ <text macro="year-date"/>
+ </macro>
+ <macro name="editor-text-short">
+ <names variable="editor">
+ <name name-as-sort-order="all" form="short" font-variant="small-caps" delimiter-precedes-last="never" and="text" delimiter=", "/>
+ </names>
+ <text value=" (éd.) "/>
adam3smith
adam3smith Feb 27, 2014 Owner

I'm concerned about this - since it's not wrapped in a group, I'd expect this to be rendered even if there is no author. Couldn't the editor/director distinction be addressed using editorial-director (or is that not actually available in Zotero?) and you could use proper labels then. At a minimum I'd use a suffix here instead of text value. (Same for l. 85)

NMonteix
NMonteix Feb 27, 2014 Contributor

Zotero doesn't accept editorial-director. I'll move for suffix indeed.

@adam3smith adam3smith commented on an outdated diff Feb 27, 2014
archeologie-medievale.csl
+ <choose>
+ <if type="thesis">
+ <group delimiter=", " suffix=".">
+ <text macro="title" font-style="italic"/>
+ <text variable="genre"/>
+ <text variable="publisher"/>
+ <text variable="publisher-place"/>
+ <group>
+ <text variable="number-of-pages" suffix="&#160;p."/>
+ </group>
+ </group>
+ </if>
+ <else-if type="webpage">
+ <group delimiter=" ">
+ <text macro="title" font-style="italic"/>
+ <text variable="URL" prefix="("/>
adam3smith
adam3smith Feb 27, 2014 Owner

this will probably work for almost all cases - unless the access date is missing - , but more elegantly put URL and access macro in a group and include the parentheses as affixes for the group.

@adam3smith adam3smith commented on an outdated diff Feb 27, 2014
archeologie-medievale.csl
+ <text macro="pages"/>
+ </group>
+ </else-if>
+ <else-if type="book graphic" match="any">
+ <group suffix=".">
+ <text macro="title" suffix=", "/>
+ <text macro="publisher"/>
+ <group>
+ <text variable="number-of-pages" prefix=", " suffix="&#160;p."/>
+ </group>
+ </group>
+ </else-if>
+ <else-if type="chapter paper-conference" match="any">
+ <text macro="title" quotes="true" suffix=", "/>
+ <group>
+ <text value="dans" suffix=" "/>
adam3smith
adam3smith Feb 27, 2014 Owner

use text term="in" here

@adam3smith adam3smith and 1 other commented on an outdated diff Feb 27, 2014
archeologie-medievale.csl
+ <else-if type="book graphic" match="any">
+ <group suffix=".">
+ <text macro="title" suffix=", "/>
+ <text macro="publisher"/>
+ <group>
+ <text variable="number-of-pages" prefix=", " suffix="&#160;p."/>
+ </group>
+ </group>
+ </else-if>
+ <else-if type="chapter paper-conference" match="any">
+ <text macro="title" quotes="true" suffix=", "/>
+ <group>
+ <text value="dans" suffix=" "/>
+ <text macro="editor" suffix=", "/>
+ <text variable="container-title" font-style="italic"/>
+ <text macro="publisher" prefix=", "/>
adam3smith
adam3smith Feb 27, 2014 Owner

I'd encourage you to use more group delimiters or, at a minimum, only include spaces in either prefixes or suffixes. If you have a container-title missing here (rare, but probably not impossible), you'll get ", ," in between editor and publisher. We like to avoid that.

edit: e.g. what you do for the journal article is much cleaner and more robust

NMonteix
NMonteix Feb 27, 2014 Contributor

The thing is that with the use of text term="in", I can't use ", " as a delimiter. Using prefix="dans " blocks the change of language (and contradicts the comment above).
I understand your concern, but at this point, if there is a lack of container title, that means that there is some kind of a problem in the Zotero database (the problem being to be considered as important for chapter/paper-conference types), don't you think?

adam3smith
adam3smith Feb 27, 2014 Owner

just nest it:
<group delimiter=", "> <group delimiter=" "> <text term="in"/> <text macro="editor"/> </group> <text variable="container-title" font-style="italic"/> <text macro="publisher"/> </group>

NMonteix
NMonteix Feb 27, 2014 Contributor

I see...
Well... next time?

adam3smith
adam3smith Feb 27, 2014 Owner

the second best solution is to be consistent in where you put spaces. If
you always keep spaces in the prefix field, you won't get double
punctuation. But oh well.

On Thu, Feb 27, 2014 at 2:01 PM, NMonteix notifications@github.com wrote:

In archeologie-medievale.csl:

  •          <else-if type="book graphic" match="any">
    
  •            <group suffix=".">
    
  •              <text macro="title" suffix=", "/>
    
  •              <text macro="publisher"/>
    
  •              <group>
    
  •                <text variable="number-of-pages" prefix=", " suffix="&#160;p."/>
    
  •              </group>
    
  •            </group>
    
  •          </else-if>
    
  •          <else-if type="chapter paper-conference" match="any">
    
  •            <text macro="title" quotes="true" suffix=", "/>
    
  •            <group>
    
  •              <text value="dans" suffix=" "/>
    
  •              <text macro="editor" suffix=", "/>
    
  •              <text variable="container-title" font-style="italic"/>
    
  •              <text macro="publisher" prefix=", "/>
    

I see...
Well... next time?

Reply to this email directly or view it on GitHubhttps://github.com/citation-style-language/styles/pull/858/files#r10142121
.

Sebastian Karcher
Ph.D. Candidate
Department of Political Science
Northwestern University

NMonteix
NMonteix Feb 27, 2014 Contributor

I am generally struggling with this. Next style, more groups...

Owner

See comments in line. You don't have to address all of them, but it'd make the style better. Definitely fix the (ed.) in text value, that's a bad idea.

Contributor

Normally (hopefully...) each of your proposed changes has been addressed (except for the last one, see comment in line)...

@adam3smith adam3smith merged commit 3a771b4 into citation-style-language:master Feb 27, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment