core: remove dependency on RTTI from dynamic_component_cast, add IsGameProcess checks

Author: blattersturm

code/client/citicore/ComponentLoader.h

@@ -11,6 +11,8 @@
 #include "EventCore.h"
 #include <unordered_map>
 
+#include <boost/type_index.hpp>
+
 //
 // An identifier for a Fx component. These are formatted like `category:subcategory:...[version]`.
 // 
@@ -77,6 +79,16 @@ class EXPORTED_TYPE Component : public fwRefCountable
     {
         return true;
     }
+
+	virtual inline bool IsA(uint32_t type)
+	{
+		return false;
+	}
+
+	virtual inline void* As(uint32_t type)
+	{
+		return nullptr;
+	}
 };
 
 class EXPORTED_TYPE RunnableComponent : public Component
@@ -231,12 +243,12 @@ std::queue<TListEntry> SortDependencyList(const std::vector<TListEntry>& list)
 template<typename T, typename TOther>
 inline T dynamic_component_cast(TOther value)
 {
-	try
-	{
-		return dynamic_cast<T>(value);
-	}
-	catch (std::bad_typeid)
+	auto type = HashString(boost::typeindex::type_id<std::remove_pointer_t<T>>().pretty_name().substr(6).c_str());
+
+	if (value->IsA(type))
 	{
-		return T();
+		return reinterpret_cast<T>(value->As(type));
 	}
+
+	return T();
 }

code/client/citicore/ResumeComponent.h

@@ -23,6 +23,26 @@ class LifeCycleComponentBase : public TBaseComponent, public LifeCycleComponent
 	{
 		// empty
 	}
+
+	virtual bool IsA(uint32_t type) override
+	{
+		if (type == HashString("LifeCycleComponent"))
+		{
+			return true;
+		}
+
+		return TBaseComponent::IsA(type);
+	}
+
+	virtual void* As(uint32_t type) override
+	{
+		if (type == HashString("LifeCycleComponent"))
+		{
+			return static_cast<LifeCycleComponent*>(this);
+		}
+
+		return TBaseComponent::As(type);
+	}
 };
 
 void Component_RunPreInit();
@@ -31,13 +51,8 @@ template<typename TBaseComponent>
 class LifeCyclePreInitComponentBase : public LifeCycleComponentBase<TBaseComponent>
 {
 public:
-	virtual void PreResumeGame() override
-	{
-		OnResumeGame();
-	}
-
 	virtual void PreInitGame() override
 	{
 		Component_RunPreInit();
 	}
-};
+};

code/client/citicore/ToolComponentHelpers.h

@@ -138,5 +138,25 @@ class ToolComponentBase : public TBaseComponent, public ToolComponent
 
 		return nullptr;
 	}
+
+	virtual bool IsA(uint32_t type) override
+	{
+		if (type == HashString("ToolComponent"))
+		{
+			return true;
+		}
+
+		return TBaseComponent::IsA(type);
+	}
+
+	virtual void* As(uint32_t type) override
+	{
+		if (type == HashString("ToolComponent"))
+		{
+			return static_cast<ToolComponent*>(this);
+		}
+
+		return TBaseComponent::As(type);
+	}
 };
 

code/client/citicore/om/OMComponent.h

@@ -162,4 +162,24 @@ class OMComponentBase : public TBaseComponent, public OMComponent
 
 		return retval;
 	}
+
+	virtual bool IsA(uint32_t type) override
+	{
+		if (type == HashString("OMComponent"))
+		{
+			return true;
+		}
+
+		return TBaseComponent::IsA(type);
+	}
+
+	virtual void* As(uint32_t type) override
+	{
+		if (type == HashString("OMComponent"))
+		{
+			return static_cast<OMComponent*>(this);
+		}
+
+		return TBaseComponent::As(type);
+	}
 };

code/client/launcher/CitizenGame.cpp

@@ -411,7 +411,7 @@ void CitizenGame::Launch(const std::wstring& gamePath, bool isMainGame)
 	static HostSharedData<CfxState> initState("CfxInitState");
 
 	// prevent accidental duplicate instances
-	if (isMainGame && !initState->IsMasterProcess())
+	if (isMainGame && !initState->IsMasterProcess() && !initState->IsGameProcess())
 	{
 		return;
 	}

code/client/shared/CfxState.h

@@ -5,6 +5,7 @@
 struct CfxState
 {
 	int initialPid;
+	int gamePid;
 
 	bool inJobObject;
 	bool running;
@@ -15,6 +16,7 @@ struct CfxState
 	{
 		running = true;
 		initialPid = GetCurrentProcessId();
+		gamePid = 0;
 
 		// get the init path
 		wchar_t modulePath[512];
@@ -38,4 +40,9 @@ struct CfxState
 	{
 		return (initialPid == GetCurrentProcessId());
 	}
-};
+
+	inline bool IsGameProcess()
+	{
+		return (gamePid == GetCurrentProcessId());
+	}
+};

code/components/devcon/src/DevConServer.cpp

@@ -191,7 +191,7 @@ static InitFunction initFunction([]()
 
 	console::CoreAddPrintListener(DevConPrintListener);
 
-	if (!hostData->IsMasterProcess())
+	if (!hostData->IsMasterProcess() && !hostData->IsGameProcess())
 	{
 		return;
 	}

code/components/glue/src/ConnectToNative.cpp

@@ -448,7 +448,7 @@ void Component_RunPreInit()
 
 	static HostSharedData<CfxState> hostData("CfxInitState");
 
-	if (hostData->IsMasterProcess())
+	if (hostData->IsMasterProcess() || hostData->IsGameProcess())
 	{
 		rage::OnInitFunctionStart.Connect([](rage::InitFunctionType type)
 		{

code/components/steam/src/SteamComponent.cpp

@@ -102,7 +102,7 @@ void SteamComponent::Initialize()
 	// launch the presence dummy dummy if needed
 	static HostSharedData<CfxState> hostData("CfxInitState");
 
-	if (hostData->IsMasterProcess())
+	if (hostData->IsMasterProcess() || hostData->IsGameProcess())
 	{
 		SetEnvironmentVariable(L"SteamAppId", L"218");