fix(sdk): don't duplicate entries in project explorer when renaming

apparently deleting from object using ?. expression is somehow badly transformed during optimizations pass
citizenfx · Feb 11, 2022 · 185cbc7 · 185cbc7
1 parent 88276d4
commit 185cbc7
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/ext/sdk/resources/sdk-root/shell/src/fxdk/project/browser/state/parts/FileSystem.ts b/ext/sdk/resources/sdk-root/shell/src/fxdk/project/browser/state/parts/FileSystem.ts
@@ -51,8 +51,13 @@ export class ProjectFsState implements IDisposableObject {
         const oldParentFsEntry = this.getFsEntry(update.oldParentPath);
         const newParentFsEntry = this.getFsEntry(update.newParentPath);
 
-        const oldFsEntry = oldParentFsEntry?.children[update.oldName];
-        delete oldParentFsEntry?.children[update.oldName];
+        if (!oldParentFsEntry) {
+          console.error('Unable to perform rename, no parent fs entry', { update, oldParentFsEntry, newParentFsEntry });
+          break;
+        }
+
+        const oldFsEntry = oldParentFsEntry.children[update.oldName];
+        delete oldParentFsEntry.children[update.oldName];
 
         if (oldFsEntry && newParentFsEntry) {
           oldFsEntry.name = update.newName;