From 50637e5dc48a9dd29c7dea20c30a86940454ef03 Mon Sep 17 00:00:00 2001 From: blattersturm Date: Fri, 4 Aug 2023 18:03:53 +0200 Subject: [PATCH] Revert "fix(client-registry): remove temp net id from m_clientsByNetId when 'joining'" This change was suspected (on Matrix in #main:cfx.re) to cause compat issues with some ways of handling player connections. https://matrix.to/#/!rUiwxlJvpdAOiTowFn:cfx.re/$Zy6GJR5TXYuVTb8b4EeWBKXE2oVeuYhjqQXObby23_c?via=cfx.re&via=matrix.org&via=t2bot.io This reverts commit 3800625960226478169bd4e707384b2d41259b3b. --- code/components/citizen-server-impl/src/ClientRegistry.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/code/components/citizen-server-impl/src/ClientRegistry.cpp b/code/components/citizen-server-impl/src/ClientRegistry.cpp index dd7414020f..04646b8333 100644 --- a/code/components/citizen-server-impl/src/ClientRegistry.cpp +++ b/code/components/citizen-server-impl/src/ClientRegistry.cpp @@ -223,7 +223,6 @@ namespace fx events->TriggerClientEvent("onPlayerJoining", target, client->GetNetId(), client->GetName(), bigModeSlot); } - m_clientsByNetId[oldNetID].reset(); // trigger connection handlers OnConnectedClient(client.get()); }