cloning: apply a pending clone sync before changing ownership of a migrating object

Author: blattersturm

code/components/gta-net-five/src/CloneManager.cpp

@@ -903,9 +903,6 @@ bool CloneManagerLocal::HandleCloneUpdate(const msgClone& msg)
 
 	auto obj = objIt->second;
 
-	// update client id if changed
-	CheckMigration(msg);
-
 	if (msg.GetClientId() == m_netLibrary->GetServerNetID())
 	{
 		Log("%s: our object, bailing out\n", __func__);
@@ -952,6 +949,10 @@ bool CloneManagerLocal::HandleCloneUpdate(const msgClone& msg)
 	// call post-apply
 	obj->m_1D0();
 
+	// update client id if changed
+	// this has to be done AFTER apply since the sync update might contain critical state we didn't have yet!
+	CheckMigration(msg);
+
 	ackPacket();
 
 	return true;