(ServerGameState): sv_filterRequestControl defaults to NoFilter instead of Default

[0xLuca]

The docs & the code comments say that the current default value for sv_filterRequestControl is -1 (RequestControlFilterMode::Default), which is equivalent to 2 (RequestControlFilterMode::FilterPlayer).
But in the code, the convar's default value is RequestControlFilterMode::NoFilter:

fivem/code/components/citizen-server-impl/src/state/ServerGameState.cpp

Line 5866 in 45b879f

g_requestControlVar = instance->AddVariable<int>("sv_filterRequestControl", ConVar_None, (int)RequestControlFilterMode::NoFilter, (int*)&g_requestControlFilterState);

[blattersturm]

This is intentional and was done while pending feedback on the feature, while still being able to bump the 'recommended' server release without inducing a behavior change.

Since people still haven't provided sufficient feedback, this also still hasn't changed.

See the commit history for the reasoning as well: f07c619

[0xLuca]

This is intentional and was done while pending feedback on the feature, while still being able to bump the 'recommended' server release without inducing a behavior change.

Since people still haven't provided sufficient feedback, this also still hasn't changed.

See the commit history for the reasoning as well: f07c619

What feedback do you need? Is there anything we should test? I think this (currently less known) feature would help a few servers regarding "cheaters" using external software to take ownership of foreign vehicles.

[blattersturm]

I do not know at this time. It has been a while, so I mostly forgot the specifics.

I presume it was related to multiple server owners trying the flag in diverse yet realistic setups and seeing in what way real-world scripts got affected by it and reporting complications in adapting scripts to work without this, but I'm not sure as I've moved on from this feature for months by now.

Even the initial feature being merged happened a month or so after it got implemented pending some people trying it, so by then most the specifics were already lost.

At this time I also do not have the bandwidth to consider anything regarding this feature, nor do I presume anyone else does insofar as they are available, so I am going to lock this 'issue report' for the time being as it is not actionable. I would kindly request you to not bring this subject up anywhere else either (other than perhaps the forums) unless you have actionable feedback that won't induce yet another months-long cycle of an attempted change being made and then brought up months later as being wrong/incomplete/etc.

[blattersturm]

In fact, I've taken the initiative and made a forum topic for this: https://forum.cfx.re/t/discussion-on-the-built-in-request-control-filtering-feature/4887321

Please try to remain civil and blameless, however.