Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clr): add ClientScript and ServerScript, allow missing types #608

Merged
merged 1 commit into from Jan 11, 2021

Conversation

tie
Copy link
Contributor

@tie tie commented Jan 8, 2021

This change adds ClientScript and ServerScript classes that are present
in the respective environments to differentiate client and server sided
scripts. This also allows the C# and F# compilers to unambiguously link
against the correct libraries when referencing both assemblies.

In addition, we handle an exception that is thrown when loading types
with missing assemblies, e.g. ServerScript is missing on the client.

See https://forum.cfx.re/t/2006775

This change adds ClientScript and ServerScript classes that are present
in the respective environments to differentiate client and server sided
scripts. This also allows the C# and F# compilers to unambiguously link
against the correct libraries when referencing both assemblies.

In addition, we handle an exception that is thrown when loading types
with missing assemblies, e.g. ServerScript is missing on the client.

See also https://forum.cfx.re/t/2006775
@blattersturm blattersturm merged commit 5077f4e into citizenfx:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants