-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation on native for drawing Penned In spheres #111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build failure. 🙁
GRAPHICS/N_0x799017f9e3b10112.md
Outdated
| @@ -5,17 +5,17 @@ ns: GRAPHICS | |||
|
|
|||
| ```c | |||
| // 0x799017F9E3B10112 | |||
| void _0x799017F9E3B10112(Any p0, Any p1, Any p2, Any p3, Any p4, Any p5, Any p6, Any p7); | |||
| void _0x799017F9E3B10112(float x, float y, float z, float radius, int r, int g, int b, float opacitiy); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opacitiy -> opacity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't changing parameter types an ABI breaking change? I'm looking for some clarification before I submit a PR on a separate unnamed native that is using Any instead of Float.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly depends on the native, if it requires floats to work, and it's an undocumented native chances are slim that anyone is actually using it in scripts that break like that. Instead if it requires floats instead of ints then usually in languages like C#, you'd be manually invoking the native anyway because there's no other way to do this.
So yes it is a backwards compatibility issue in most cases, but it depends on the native.
It's definitely |
|
this includes an image hosted on a personal server, wouldn't it be better to upload the image to a service such as imgur or wew.wtf? that way its chances of getting lost and becoming a dead link would be greatly reduced... |
This should hopefully A) Not break the reference and B) Add some documentation for a native which draws the spheres seen in Penned In. Maybe @TomGrobbe can wizard up a name for it :p