Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation on native for drawing Penned In spheres #111

Merged
merged 2 commits into from
Apr 24, 2019
Merged

Added documentation on native for drawing Penned In spheres #111

merged 2 commits into from
Apr 24, 2019

Conversation

logan-mcgee
Copy link
Contributor

This should hopefully A) Not break the reference and B) Add some documentation for a native which draws the spheres seen in Penned In. Maybe @TomGrobbe can wizard up a name for it :p

Copy link
Contributor

@blattersturm blattersturm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build failure. 🙁

@@ -5,17 +5,17 @@ ns: GRAPHICS

```c
// 0x799017F9E3B10112
void _0x799017F9E3B10112(Any p0, Any p1, Any p2, Any p3, Any p4, Any p5, Any p6, Any p7);
void _0x799017F9E3B10112(float x, float y, float z, float radius, int r, int g, int b, float opacitiy);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opacitiy -> opacity?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't changing parameter types an ABI breaking change? I'm looking for some clarification before I submit a PR on a separate unnamed native that is using Any instead of Float.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly depends on the native, if it requires floats to work, and it's an undocumented native chances are slim that anyone is actually using it in scripts that break like that. Instead if it requires floats instead of ints then usually in languages like C#, you'd be manually invoking the native anyway because there's no other way to do this.

So yes it is a backwards compatibility issue in most cases, but it depends on the native.

@TomGrobbe
Copy link
Contributor

Maybe @TomGrobbe can wizard up a name for it :p

It's definitely DRAW_m/o/p.... something. but since there's no joaat hash we can't confirm or bruteforce a name.

@stannum-cfx stannum-cfx merged commit 6a5afe1 into citizenfx:master Apr 24, 2019
@vecchiotom
Copy link

vecchiotom commented Apr 25, 2019

this includes an image hosted on a personal server, wouldn't it be better to upload the image to a service such as imgur or wew.wtf? that way its chances of getting lost and becoming a dead link would be greatly reduced...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants