Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update N_0x8aa9180de2fedd45.md #883

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Conversation

Wetter42
Copy link
Contributor

@Wetter42 Wetter42 commented Jun 2, 2023

Added a test native...if you commit this, there are plenty more where this came from - just be sure to add the invokenative as an update to this native so we can keep up with builds!

Before you submit this PR, please make sure:

  • You have read the contribution guidelines
  • You include an example that validates your change
  • Your English is grammatically correct

Added a test native...if you commit this, there are plenty more where this came from - just be sure to add the invokenative as an update to this native so we can keep up with builds!
Copy link
Contributor

@4mmonium 4mmonium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look over what I commented, thanks!

Removed code block, renamed native, and added some additional description for cleanliness and verbosity!

```c
// 0x8AA9180DE2FEDD45 0xAE040377
void _0x8AA9180DE2FEDD45(Vehicle vehicle, BOOL p1);
void _0x8AA9180DE2FEDD45(Vehicle vehicle, BOOL enableobstacleavoidance);
Copy link
Contributor

@4mmonium 4mmonium Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename _0x8AA9180DE2FEDD45 to _ENABLE_AIRCRAFT_OBSTACLE_AVOIDANCE.
enableobstacleavoidance could also be simplified to avoidObstacles?

## Parameters
* **vehicle**:
* **p1**:
* **enableobstacleavoidance**:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the event you re-name the parameter I mentioned up above, this should also be renamed to avoidObstacles.

Copy link
Contributor

@4mmonium 4mmonium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I requested some changes, all in all, your native documentation would end up looking like the file I attached.

EnableAircraftObstacleAvoidance.md

@Wetter42
Copy link
Contributor Author

Roger that - I'll make the necessary changes after work; Sorry about that peeps;

Also, question - I've noticed that I have to invokenative for my appropriate build or the behavior becomes a bit...unstable - Is this something you guys will account for after the pull request completes, or will you need another ticket / forumpost? ETC?

Let me know!
Thanks!

Simplified the second argument (arg 2), renamed native (based on recommendation) and added alias
@Wetter42
Copy link
Contributor Author

Done, and done! Do you guys have internal docs on updating natives? I have a few changes to existing one's I'd like to change...

Also, specified that this is for AI behavior
---
## _0x8AA9180DE2FEDD45
## EnableAircraftObstacleAvoidance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be uppercase, I sent you an example file in a previous comment, but I'll send it again just in case 😅

i.e. _ENABLE_AIRCRAFT_OBSTACLE_AVOIDANCE

EnableAircraftObstacleAvoidance(1).md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geez man! I'm so sorry! I thought I made the appropriate changes! I'll get it eventually! LOL

Anyways, hopefully this will work, but if anything's missing, please let me know! I promise I'm learning! 🤣

@4mmonium
Copy link
Contributor

4mmonium commented Jun 29, 2023

Done, and done! Do you guys have internal docs on updating natives? I have a few changes to existing one's I'd like to change...

If you're referring to the native contribution guide, it's here, if it's about actual FiveM natives, most are located here and PRs for that belong to the main FiveM repository.

You know what they say...5 times the charm, LOL!


Thanks for your patience as I don't do this often (as you can tell, LOL)
@titanium-cfx titanium-cfx merged commit aa6c42d into citizenfx:master Jul 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants