-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update N_0x8aa9180de2fedd45.md #883
Conversation
Added a test native...if you commit this, there are plenty more where this came from - just be sure to add the invokenative as an update to this native so we can keep up with builds!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look over what I commented, thanks!
Removed code block, renamed native, and added some additional description for cleanliness and verbosity!
VEHICLE/N_0x8aa9180de2fedd45.md
Outdated
|
||
```c | ||
// 0x8AA9180DE2FEDD45 0xAE040377 | ||
void _0x8AA9180DE2FEDD45(Vehicle vehicle, BOOL p1); | ||
void _0x8AA9180DE2FEDD45(Vehicle vehicle, BOOL enableobstacleavoidance); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename _0x8AA9180DE2FEDD45
to _ENABLE_AIRCRAFT_OBSTACLE_AVOIDANCE
.
enableobstacleavoidance
could also be simplified to avoidObstacles
?
VEHICLE/N_0x8aa9180de2fedd45.md
Outdated
## Parameters | ||
* **vehicle**: | ||
* **p1**: | ||
* **enableobstacleavoidance**: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the event you re-name the parameter I mentioned up above, this should also be renamed to avoidObstacles
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I requested some changes, all in all, your native documentation would end up looking like the file I attached.
Roger that - I'll make the necessary changes after work; Sorry about that peeps; Also, question - I've noticed that I have to invokenative for my appropriate build or the behavior becomes a bit...unstable - Is this something you guys will account for after the pull request completes, or will you need another ticket / forumpost? ETC? Let me know! |
Simplified the second argument (arg 2), renamed native (based on recommendation) and added alias
Done, and done! Do you guys have internal docs on updating natives? I have a few changes to existing one's I'd like to change... |
Also, specified that this is for AI behavior
VEHICLE/N_0x8aa9180de2fedd45.md
Outdated
--- | ||
## _0x8AA9180DE2FEDD45 | ||
## EnableAircraftObstacleAvoidance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be uppercase, I sent you an example file in a previous comment, but I'll send it again just in case 😅
i.e. _ENABLE_AIRCRAFT_OBSTACLE_AVOIDANCE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Geez man! I'm so sorry! I thought I made the appropriate changes! I'll get it eventually! LOL
Anyways, hopefully this will work, but if anything's missing, please let me know! I promise I'm learning! 🤣
If you're referring to the native contribution guide, it's here, if it's about actual FiveM natives, most are located here and PRs for that belong to the main FiveM repository. |
You know what they say...5 times the charm, LOL! Thanks for your patience as I don't do this often (as you can tell, LOL)
Added a test native...if you commit this, there are plenty more where this came from - just be sure to add the invokenative as an update to this native so we can keep up with builds!
Before you submit this PR, please make sure: