New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IPC helper & ServiceFramework on our services #2531

Closed
wwylele opened this Issue Feb 5, 2017 · 7 comments

Comments

Projects
None yet
6 participants
@wwylele
Member

wwylele commented Feb 5, 2017

Since #2027 is merged, we should get started to apply it to our services. This issue is to record the assignment of each service and the process of them.

Update: we also need to convert them into new ServiceFramework and ditch some old interface of IPCHelpers. Please do not use those [[deprecated]] functions (including Push/PopHandle) in the new ServiceFramework.

We have the following services, neglecting services without any actual implemented/stubbed functions: (bold ones are service that are already implemented a lot and should be taken more care)

Please comment below if you are going to take over one from this list.

Also note that @Lectem will have follow up PRs to IPC helper itself. Currently these functions are planed to add: Already done

@JohnnyPony

This comment has been minimized.

JohnnyPony commented Feb 16, 2017

I am currently working on the ac service.

@wwylele

This comment has been minimized.

Member

wwylele commented Apr 7, 2017

Unresolved problems presented in #2532 :
Most real system model checks param translation descriptor, and returns ERROR_INVALID_DESCRIPTOR on failure. Currently the check is handled by IPCHelper with DEBUG_ASSERT_MSG. We need to consider the importance of this (usually game won't hit this error) and think of a proper way to handle it.

@tgsm

This comment has been minimized.

Contributor

tgsm commented Apr 21, 2017

#2532 is merged, so I am assuming ldr:ro can be checked off now.

@wwylele

This comment has been minimized.

Member

wwylele commented May 23, 2017

Probably we can wait for #2646, and do IPC helper and log rewrite for each module at the same time

@yuriks

This comment has been minimized.

Member

yuriks commented May 23, 2017

I don't think that's a good idea. If you can do and submit 2 things separately then you should. Makes it easier to review, avoid conflicts, etc.

@wwylele

This comment has been minimized.

Member

wwylele commented Dec 4, 2017

Update: as the new service framework fully implemented, all services need to transform to it.

@lioncash

This comment has been minimized.

Member

lioncash commented Dec 8, 2017

I'll claim the mic service to help out with this

@wwylele wwylele changed the title from Use IPC helper on our services to Use IPC helper & ServiceFramework on our services Jan 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment