HLE/FS: Implemented FSFile::OpenSubFile. #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
reviewed
Dec 7, 2017
| bool subfile; ///< Whether this file was opened via OpenSubFile or not. | ||
| }; | ||
|
|
||
| std::vector<SessionSlot> session_slots; |
| std::unique_ptr<FileSys::FileBackend> backend; ///< File backend interface | ||
|
|
||
| /// Creates a new session to this File and returns the ClientSession part of the connection. | ||
| Kernel::SharedPtr<Kernel::ClientSession> Connect(); |
There was a problem hiding this comment.
"core/hle/kernel/kernel.h" needs to be included.
| } | ||
|
|
||
| File::SessionSlot& File::GetSessionSlot(Kernel::SharedPtr<Kernel::ServerSession> session) { | ||
| auto itr = std::find_if(session_slots.begin(), session_slots.end(), |
There was a problem hiding this comment.
<algorithm> needs to be included.
|
Addressed |
bunnei
approved these changes
Dec 7, 2017
|
FBI causes citra to crash trying to install cias. |
|
@valentinvanelslande how is that related to this PR |
The File class now holds a list of connected sessions along with data unique to each session. A subfile is a window into an existing file. They have a few limitations compared to normal files: * They can't be written to. * They can't be flushed. * Their size can not be changed. * New subfiles can't be created from another subfile.
|
Should be fixed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The File class now holds a list of connected sessions along with data unique to each session.
A subfile is a window into an existing file. They have a few limitations compared to normal files:
This function is used by the DLP module to open the DLPChild CIA from the game's RomFS.
This change is