New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

citra_qt: Add Continue/Pause & Toggle Speed Limit hotkeys #3594

Merged
merged 1 commit into from May 30, 2018

Conversation

Projects
None yet
7 participants
@valentinvanelslande
Contributor

valentinvanelslande commented Mar 28, 2018

Default hotkeys:
Continue/Pause: F4
Toggle Speed Limit: CTRL+Z


This change is Reviewable

@adityaruplaha

This comment has been minimized.

Contributor

adityaruplaha commented Mar 29, 2018

Excuse me, but I've already made one for Toggle Speed Limit (Y) in adityaruplaha/new-frame-limit-hotkey.

@jabroany

This comment has been minimized.

jabroany commented Apr 4, 2018

This will be such a huge improvement to the user experience after the current increase in speed.

@LogPod

This comment has been minimized.

LogPod commented Apr 5, 2018

Could make the default key for Toggle Speed Limit, Tab?
Edit: Looks like that key doesn't even work anyway

@jabroany

This comment has been minimized.

jabroany commented Apr 5, 2018

Indeed, Tab would be to prefer compared to Ctrl+z. It'll at least be more in sync with other emulators

And the key works for me. As a matter of fact with joy2key (for the sole purpose of mapping ctrl+z to controller) it became a perfect experience 👍

RegisterHotkey("Main Window", "Swap Screens", QKeySequence(tr("F9")));
RegisterHotkey("Main Window", "Toggle Screen Layout", QKeySequence(tr("F10")));
RegisterHotkey("Main Window", "Fullscreen", QKeySequence::FullScreen);
RegisterHotkey("Main Window", "Exit Fullscreen", QKeySequence(Qt::Key_Escape),
Qt::ApplicationShortcut);
RegisterHotkey("Main Window", "Toggle Speed Limit", QKeySequence("CTRL+Z"),

This comment has been minimized.

@adityaruplaha

adityaruplaha Apr 12, 2018

Contributor

This is a highly requested feature & I (and many users) will prefer it near to the most used keys. Consider using "Y" (close to D-Pad, iirc) or ";" (close to the arrow keys) by default. Or use Tab.

This comment has been minimized.

@FearlessTobi

FearlessTobi Apr 12, 2018

Contributor

I would really like Tab, because I'm used to it from other emulators, e.g. Dolphin.

@cluezbot

This comment has been minimized.

cluezbot commented Apr 16, 2018

Hi, this is neobot, using neobrain's account. I'm keeping an archive of versions of this PR:

2018-04-16T15:41:11Z: cb36f9f...valentinvanelslande:302675975efb3653071ff4831dc7274daf070163

@cluezbot

This comment has been minimized.

cluezbot commented May 28, 2018

Hi, this is neobot, using neobrain's account. I'm keeping an archive of versions of this PR:

2018-05-28T21:37:31Z: 65f5bc7...valentinvanelslande:90bcb26c3b2fdc3b5505a1fc60c288dd1950d90f

@jroweboy jroweboy merged commit 0095c20 into citra-emu:master May 30, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jroweboy

This comment has been minimized.

Member

jroweboy commented May 30, 2018

Sorry I've been so negligent about reviewing PRs. :) Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment