Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Minor multiplayer ui fixes #3676
One bug was found and reported on discord today where if you attempt to direct connect to a room that doesn't exist, and simultaneously try to join a room in the lobby, citra would pop up a message about "do you want to close the current network connection?" and if you choose yes, citra would crash. The first commit fixes this by preventing any join (through the lobby, direct connect, or hosting a new room) from happening while the network state is "Joining". The old behavior where citra pops up a message still happens if you've successfully joined a room.
The second commit was a bug I found while fixing the first. If you host a room and close it using the disconnect button in the client room, it wouldn't stop the server (as it was using the old close handler). This commit moves the Disconnect button to call the new, centralized close room handler in MultiplayerState
Hi, this is neobot, using neobrain's account. I'm keeping an archive of versions of this PR: