New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

citra_qt: add motion/touch config #4059

Merged
merged 2 commits into from Aug 26, 2018

Conversation

Projects
None yet
5 participants
@zhaowenlan1779
Member

zhaowenlan1779 commented Aug 8, 2018

These functions include reloading udp client, testing communication and configuring calibration. I also added a function to common/thread.h to use WaitFor.

Implemented a Motion/Touch... configuration dialog. Users can open this dialog by clicking a button on the Input tab. The dialog also includes CemuhookUDP server config and communication testing, and the touchpad calibration config.

I had no time to provide a screenshot now, but I will add one soon

UPD: Screenshot
image

Note: Touchpad calibration configuration is not easy to finish according to @jroweboy. I do not have a better idea for this currently though. Probably add a dialog about the process?


This change is Reviewable

@cluezbot

This comment has been minimized.

cluezbot commented Aug 8, 2018

Hi, this is neobot, using neobrain's account. I'm keeping an archive of versions of this PR:

2018-08-08T04:01:45Z: 93386ef...zhaowenlan1779:33d21c5fe9818ab78c2823a81b0edeb602d0114e

}
void ConfigureMotionTouch::closeEvent(QCloseEvent* event) {
if (!CanCloseDialog())

This comment has been minimized.

@lioncash

lioncash Aug 8, 2018

Member

This can be inverted to be in terms of the true case.

connectEvents();
}
ConfigureMotionTouch::~ConfigureMotionTouch() {}

This comment has been minimized.

@lioncash

lioncash Aug 8, 2018

Member
ConfigureMotionTouch::~ConfigureMotionTouch() = default;
.detach();
}
constexpr u16 CALIBRATION_THRESHOLD = 100;

This comment has been minimized.

@lioncash

lioncash Aug 8, 2018

Member

This can be within the function below to limit its scope

@Dartz150

This comment has been minimized.

Dartz150 commented Aug 9, 2018

Tested, works without any issue until now, only noticed a bit of framedrops in both Majora's Mask and Ocarina of Time while viewing in first person and moving fast the camera, but I remember this was also happening in the original hardware. Is a blast to play citra through Moonlight on Android with this feature enabled, feels like the real deal.

@cluezbot

This comment has been minimized.

cluezbot commented Aug 10, 2018

Hi, this is neobot, using neobrain's account. I'm keeping an archive of versions of this PR:

2018-08-10T01:30:04Z: 93386ef...zhaowenlan1779:2ba1be17b8973dd12d49590cefca239dd7f5913e

@cluezbot

This comment has been minimized.

cluezbot commented Aug 10, 2018

Hi, this is neobot, using neobrain's account. I'm keeping an archive of versions of this PR:

2018-08-10T03:21:37Z: 93386ef...zhaowenlan1779:6565f2af7a93a92b7929daffdfa7456df2f282fd

}
QMetaObject::invokeMethod(this, "UpdateLabelText", Q_ARG(QString, text));
if (status == CalibrationConfigurationJob::Status::Completed) {
cancel_button->setText(tr("OK"));

This comment has been minimized.

@zhaowenlan1779

zhaowenlan1779 Aug 10, 2018

Member

Note to myself: Only the UI thread can change the UI while this is getting called from a worker thread

Will fix

@cluezbot

This comment has been minimized.

cluezbot commented Aug 10, 2018

Hi, this is neobot, using neobrain's account. I'm keeping an archive of versions of this PR:

2018-08-10T17:00:20Z: 5e658ef...zhaowenlan1779:40e80246aa3461e2cb34331332bf3c726f2c718d

@zhaowenlan1779 zhaowenlan1779 force-pushed the zhaowenlan1779:udp-input-ui branch from 40e8024 to 19f89b4 Aug 11, 2018

@cluezbot

This comment has been minimized.

cluezbot commented Aug 11, 2018

Hi, this is neobot, using neobrain's account. I'm keeping an archive of versions of this PR:

2018-08-11T03:53:39Z: d1c364b...zhaowenlan1779:19f89b44cc236ed2cb086ca73bd05aa89c6e80f6

zhaowenlan1779 added some commits Aug 8, 2018

input_common, common: Add a few functions
These functions include reloading udp client, testing communication and configuring calibration. I also added a function to common/thread.h to use WaitFor.

@zhaowenlan1779 zhaowenlan1779 force-pushed the zhaowenlan1779:udp-input-ui branch from 19f89b4 to 8db6822 Aug 11, 2018

@cluezbot

This comment has been minimized.

cluezbot commented Aug 11, 2018

Hi, this is neobot, using neobrain's account. I'm keeping an archive of versions of this PR:

2018-08-11T06:16:56Z: 5863922...zhaowenlan1779:8db6822ee9853da92fceebecd216770a77fc4990

@jroweboy jroweboy merged commit 50270fd into citra-emu:master Aug 26, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zhaowenlan1779 zhaowenlan1779 deleted the zhaowenlan1779:udp-input-ui branch Aug 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment