Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core, citra_qt: add frame advancing to framelimiter #4282

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Projects
None yet
3 participants
@zhaowenlan1779
Copy link
Member

zhaowenlan1779 commented Oct 1, 2018

Frame advancing is a commonly used TAS feature which basically means running the game frame by frame. TASers use this feature to press exact buttons at the exact frames. This commit added frame advancing to the framelimiter and two actions to the Movie menu. The default hotkey is \ for advancing frames, and Ctrl+A for toggling frame advancing. The Advance Frame hotkey would automatically enable frame advancing if not already enabled.

Screenshot of the Movie menu after this change:
image

And yes, this conflicts with #3786 ofc, so do not tag it for canary


This change is Reviewable

core, citra_qt: add frame advancing to framelimiter
Frame advancing is a commonly used TAS feature which basically means running the game frame by frame. TASers use this feature to press exact buttons at the exact frames. This commit added frame advancing to the framelimiter and two actions to the Movie menu. The default hotkey is `\` for advancing frames, and `Ctrl+A` for toggling frame advancing. The `Advance Frame` hotkey would automatically enable frame advancing if not already enabled.

@zhaowenlan1779 zhaowenlan1779 force-pushed the zhaowenlan1779:frame-advance branch from 5dfe73d to cb775eb Oct 1, 2018

@Real96

This comment has been minimized.

Copy link

Real96 commented Oct 2, 2018

First of all, thanks a lot for this PR! It is fantastic and works great!
I have a suggestion/request: can the Enable Frame Advancing be un-toggled also using the Unpause button? In that way you don't have first to press Ctr+A and then F4 to unpause, just press F4 and the game will be unpaused

@zhaowenlan1779

This comment has been minimized.

Copy link
Member Author

zhaowenlan1779 commented Oct 2, 2018

@Real96 I'm not really sure about that. Some people might want to "continue" the game without cancelling frame advancing, and this would pretty much surprise them and probably ruin their runs as well.

@Real96

This comment has been minimized.

Copy link

Real96 commented Oct 2, 2018

@Real96 I'm not really sure about that. Some people might want to "continue" the game without cancelling frame advancing, and this would pretty much surprise them and probably ruin their runs as well.

If you click the continue button (with frame advancing toggled), the game won't unpause. You must continue clicking \ to advance frame. What is the useful thing in unpause+frame advancing toggled? Because removing the pause seems to not do anything (or almost it looks like this)

@zhaowenlan1779

This comment has been minimized.

Copy link
Member Author

zhaowenlan1779 commented Oct 2, 2018

@Real96 Well, some people might just intentionally / accidentally press Pause. with Continue = Continue + Cancel Frame Advance they won't be able to return to the previous state (Game running + Frame Advance) without losing frames anymore.

@Real96

This comment has been minimized.

Copy link

Real96 commented Oct 2, 2018

Oh, ok that's why then. Anyway it is perfect as it is! Thanks a lot for this!

@zhaowenlan1779

This comment has been minimized.

Copy link
Member Author

zhaowenlan1779 commented Oct 13, 2018

Any review?

@zhaowenlan1779

This comment has been minimized.

Copy link
Member Author

zhaowenlan1779 commented Oct 14, 2018

I will merge in 24 hours if no more comments

@zhaowenlan1779 zhaowenlan1779 merged commit 0df3227 into citra-emu:master Oct 15, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zhaowenlan1779 zhaowenlan1779 deleted the zhaowenlan1779:frame-advance branch Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.