Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: add logging #4575

Merged
merged 5 commits into from Mar 14, 2019

Conversation

Projects
None yet
4 participants
@BreadFish64
Copy link
Contributor

BreadFish64 commented Jan 17, 2019

sends logs over logcat using the color backend


This change is Reviewable

@zhaowenlan1779
Copy link
Member

zhaowenlan1779 left a comment

Generally looks okay to me, though I think you should add copyright headers everywhere

@BreadFish64 BreadFish64 force-pushed the BreadFish64:android6 branch from e979913 to 7834af5 Jan 18, 2019

@BreadFish64

This comment has been minimized.

Copy link
Contributor Author

BreadFish64 commented Jan 18, 2019

All issues should be fixed, logcat has its own backend now

@BreadFish64 BreadFish64 force-pushed the BreadFish64:android6 branch from 7834af5 to 8646b47 Jan 18, 2019

Show resolved Hide resolved src/.clang-format Outdated
Show resolved Hide resolved src/.clang-format Outdated
Show resolved Hide resolved src/.clang-format Outdated
Show resolved Hide resolved src/android/app/src/main/java/org/citra_emu/citra/ui/main/MainActivity.java Outdated

@BreadFish64 BreadFish64 force-pushed the BreadFish64:android6 branch from 8646b47 to e62a5c3 Jan 18, 2019

@BreadFish64

This comment has been minimized.

Copy link
Contributor Author

BreadFish64 commented Jan 18, 2019

took out the aforementioned clang format properties and fixed the builder usage

@BreadFish64 BreadFish64 force-pushed the BreadFish64:android6 branch from 62f7bc3 to e62a5c3 Jan 24, 2019

@BreadFish64

This comment has been minimized.

Copy link
Contributor Author

BreadFish64 commented Jan 24, 2019

The GetUserPath function should be refactored but @wwylele requested to separate that into a different PR.

@BreadFish64 BreadFish64 force-pushed the BreadFish64:android6 branch from e62a5c3 to a3619f3 Feb 22, 2019

@BreadFish64

This comment has been minimized.

Copy link
Contributor Author

BreadFish64 commented Mar 8, 2019

This is on hold until I have time to fix the build issues.

@BreadFish64 BreadFish64 force-pushed the BreadFish64:android6 branch from e902ac0 to f767b5f Mar 10, 2019

@BreadFish64

This comment has been minimized.

Copy link
Contributor Author

BreadFish64 commented Mar 10, 2019

MSVC error is unrelated, this should be ready

remove Common::TrimSourcePath
wwylele / 白疾風Today at 6:14 PM
I doubt the performance of constructing regex everytime the function is called
Is TrimSourcePath only called by logging? if so, you can move the implementation into logging, and cache the regex object into global
This function is probably too specific to be in common anyway

@wwylele wwylele merged commit fd7730e into citra-emu:master Mar 14, 2019

3 checks passed

ci/bitrise/4ccd8e5720f0d13b/pr Passed - citra
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.