Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement scripting over plain UDP #4609

Merged
merged 3 commits into from Feb 8, 2019

Conversation

Projects
None yet
3 participants
@wwylele
Copy link
Member

commented Jan 29, 2019

The deadline I gave was over, so now I nuked libzmq dependency.

The udp_server.cpp file wasn't written from scratch but adapted from the original zmq_server.cpp. It might contain some unusual code style from me.

Also removed the option in cmake and always enable scripting because now it costs basically nothing.


This change is Reviewable

Show resolved Hide resolved src/core/rpc/server.cpp Outdated

@wwylele wwylele force-pushed the wwylele:nuke-zmq branch from 8bf45bf to 55ff0b7 Jan 31, 2019

#include <thread>
#include <boost/asio.hpp>
#include "common/common_types.h"
#include "core/core.h"

This comment has been minimized.

Copy link
@zhaowenlan1779

zhaowenlan1779 Feb 2, 2019

Member

where is this used?

This comment has been minimized.

Copy link
@wwylele

wwylele Feb 2, 2019

Author Member

No where. Leftover from old code.

@wwylele wwylele force-pushed the wwylele:nuke-zmq branch 2 times, most recently from 9f8fc0b to f9c6fe6 Feb 2, 2019

@wwylele wwylele force-pushed the wwylele:nuke-zmq branch from f9c6fe6 to 008197a Feb 2, 2019

@wwylele wwylele merged commit 687fa01 into citra-emu:master Feb 8, 2019

3 checks passed

ci/bitrise/4ccd8e5720f0d13b/pr Passed - citra
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wwylele wwylele deleted the wwylele:nuke-zmq branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.