Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

citra-qt: Implement Mii selector applet #4635

Merged
merged 5 commits into from Apr 7, 2019

Conversation

FearlessTobi
Copy link
Contributor

@FearlessTobi FearlessTobi commented Feb 10, 2019

First, a big thanks to @valentinvanelslande for providing #4345 as base for this. I've tried to clean it up and address most of the review comments on it.

This PR aims to add a basic HLE replacement for the LLE Mii selector.
When a game requests you to chose a Mii, this dialog appears:
unbenannt

In case you don't have any Miis, it shows this dialog, asking you if you want to use the Citra standard Mii:
unbenannt2

As always, this implementation is QT only and for SDL the behavior stays the same.

This HLE implementation is also affected by #4634.


This change is Reviewable

@FearlessTobi FearlessTobi requested review from zhaowenlan1779 and wwylele and removed request for zhaowenlan1779 Feb 10, 2019
src/core/hle/applets/mii_selector.cpp Show resolved Hide resolved
src/core/frontend/applets/mii_selector.h Outdated Show resolved Hide resolved
src/core/frontend/applets/mii_selector.h Outdated Show resolved Hide resolved
src/citra_qt/applets/mii_selector.cpp Outdated Show resolved Hide resolved
src/citra_qt/applets/mii_selector.cpp Outdated Show resolved Hide resolved
src/citra_qt/applets/mii_selector.h Outdated Show resolved Hide resolved
src/core/hle/applets/mii_selector.cpp Outdated Show resolved Hide resolved
src/core/frontend/applets/mii_selector.h Outdated Show resolved Hide resolved
src/citra_qt/applets/mii_selector.cpp Outdated Show resolved Hide resolved
src/citra_qt/applets/mii_selector.cpp Outdated Show resolved Hide resolved
src/citra_qt/applets/mii_selector.cpp Outdated Show resolved Hide resolved
src/citra_qt/applets/mii_selector.cpp Outdated Show resolved Hide resolved
src/core/frontend/applets/mii_selector.h Show resolved Hide resolved
src/citra_qt/applets/mii_selector.h Show resolved Hide resolved
src/citra_qt/applets/mii_selector.h Show resolved Hide resolved
src/core/frontend/applets/mii_selector.cpp Outdated Show resolved Hide resolved
src/citra_qt/applets/mii_selector.cpp Outdated Show resolved Hide resolved
src/core/hle/applets/buttons.h Outdated Show resolved Hide resolved
src/core/hle/applets/mii_selector.h Outdated Show resolved Hide resolved
src/citra_qt/applets/mii_selector.cpp Outdated Show resolved Hide resolved
src/citra_qt/applets/mii_selector.cpp Outdated Show resolved Hide resolved
src/core/file_sys/archive_backend.h Outdated Show resolved Hide resolved
@FearlessTobi FearlessTobi force-pushed the mii-thingy-v9999 branch 2 times, most recently from a64cdad to d69e939 Compare Apr 7, 2019
@wwylele wwylele merged commit 9fb5cb5 into citra-emu:master Apr 7, 2019
2 of 4 checks passed
@FearlessTobi FearlessTobi deleted the mii-thingy-v9999 branch Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants