Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nfc: Improve implementation of GetAmiiboConfig #4688

Merged
merged 1 commit into from Mar 14, 2019

Conversation

FearlessTobi
Copy link
Contributor

@FearlessTobi FearlessTobi commented Mar 12, 2019

When making the initial implementation, I forgot to add the series variable to the AmiiboConfig struct.
With this PR it is added and many of the AmiiboConfig fields get their proper values now.
The loading of the Amiibo data that is added here has been hwtested.

This fixes Amiibos in Yoshis Woolly World, Smash (partially) and probably other games too.

(I'm planning to further improve the Amiibo implementation and add a way of Amiibo AppData loading sometime in the future.)


This change is Reviewable

When making the initial implementation, I forgot to add the series variable to the AmiiboConfig struct.
With this PR it is added and many of the AmiiboConfig fields get their proper values now.
The loading of the Amiibo data that is added here has been hwtested.

This fixes Amiibos in Yoshis Woolly World, Smash (partially) and probably other games too.
@FearlessTobi
Copy link
Contributor Author

FearlessTobi commented Mar 12, 2019

Appveyor mingw timed out.

@wwylele wwylele merged commit 9c5dca1 into citra-emu:master Mar 14, 2019
2 of 3 checks passed
@FearlessTobi FearlessTobi deleted the moar-nfc branch Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants