applets/swkbd: Add callback support #4700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwylele
reviewed
Mar 17, 2019
| @@ -117,11 +133,14 @@ class SoftwareKeyboard { | |||
| protected: | |||
| KeyboardConfig config; | |||
| KeyboardData data; | |||
|
|
|||
| std::atomic_bool data_ready = false; | |||
There was a problem hiding this comment.
My gut tells me this kind of construction could be converted to std::future<KeyboardData> data. I am not sure about the real reason, so I just say this as a reference.
wwylele
reviewed
Mar 17, 2019
wwylele
approved these changes
Apr 17, 2019
|
I'll merge this soon if no more comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Implements callbacks in the HLE swkbd applet by sending the config (containing text offset and length) as a parameter of signal type
Message. The application should then send the callback result parameter, also using signal typeMessage.If the result is
Close, an error dialog will be shown and then the applet will exit with codeBannedInput. If the result isContinue, an error dialog will be shown and the user will be asked for input again.Slight cleanups are also done to the code like replacing pointers with references.
Fix #4568
This change is