Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gl_rasterizer: correct supress_mipmap_for_cube logic #4822

merged 1 commit into from Jul 6, 2019


Copy link

@wwylele wwylele commented Jul 6, 2019

The previous version would break when the state changes from (cube=true,mipmap=false) -> (cube=true,mipmap=true)

Meant to fix #4821 but I didn't test. @tom-overton could you help?

This change is Reviewable

The previous version would break when the state changes from (cube=true,mipmap=false) -> (cube=true,mipmap=true)
Copy link

tom-overton commented Jul 6, 2019

I can confirm this fixes #4821, thanks for the quick response!

B3n30 approved these changes Jul 6, 2019
Copy link

@B3n30 B3n30 left a comment

looks fine

Copy link

@FearlessTobi FearlessTobi left a comment

Not really familiar with video_core, but LGTM

Copy link

@zhaowenlan1779 zhaowenlan1779 left a comment

Emm I do not really know much about video core either but code lgtm

@zhaowenlan1779 zhaowenlan1779 merged commit 46d552b into citra-emu:master Jul 6, 2019
2 of 3 checks passed
@wwylele wwylele deleted the mipmap-cub branch Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

5 participants