New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 'Accurate Geometry Shader' setting #4879
Conversation
I thought this was supposed to be |
Can anyone test other games that use Geo shaders (e.g. Layton games) and check for performance differences? |
@Dragios |
While it's true the discussion on Discord was about Since it's on by default I figured there is no reason to ever have it off. |
There is more code in gl_shader_gen and other files that can be deleted. But I guess this can be in a second PR
Codewise LGTM, but I'm wondering if there's any persuasive data/test that shows how this option has no impact on, or even improves performance? (Probably could use some #4882)
Some internal testing indeed shows that disabling accurate GS doesn't help performance, and sometimes even make it worse. I am going to merge this after coordinating the server side change. |
This setting is currently set to be enabled by default and when disabled causes performance loss in games that use GS and can cause graphical glitches. There should be no instance where turning it off is beneficial so let's just remove the option to do so.
This change is