Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'Accurate Geometry Shader' setting #4879

Merged
merged 1 commit into from Aug 18, 2019

Conversation

tywald
Copy link
Contributor

@tywald tywald commented Aug 12, 2019

This setting is currently set to be enabled by default and when disabled causes performance loss in games that use GS and can cause graphical glitches. There should be no instance where turning it off is beneficial so let's just remove the option to do so.


This change is Reviewable

@Dragios
Copy link
Contributor

Dragios commented Aug 12, 2019

I thought this was supposed to be Accurate Multiplication forced turned on and not Accurate Geometry Shader?

@FearlessTobi
Copy link
Contributor

FearlessTobi commented Aug 12, 2019

Can anyone test other games that use Geo shaders (e.g. Layton games) and check for performance differences?

@RocketRobz
Copy link

RocketRobz commented Aug 12, 2019

@Dragios Accurate Multiplication still crashes Citra for me, whenever 3D tries to be rendered, so that setting shouldn't be removed, if that's what you mean.

@tywald
Copy link
Contributor Author

tywald commented Aug 12, 2019

I thought this was supposed to be Accurate Multiplication forced turned on and not Accurate Geometry Shader?

While it's true the discussion on Discord was about Accurate Multiplication, I proposed a removal regarding Accurate Geometry Shader because I noticed when it's turned off for example in MH4U decreased the performance and would cause graphical glitches.

Since it's on by default I figured there is no reason to ever have it off.

Copy link
Member

@wwylele wwylele left a comment

There is more code in gl_shader_gen and other files that can be deleted. But I guess this can be in a second PR

Copy link
Member

@zhaowenlan1779 zhaowenlan1779 left a comment

Codewise LGTM, but I'm wondering if there's any persuasive data/test that shows how this option has no impact on, or even improves performance? (Probably could use some #4882)

@wwylele
Copy link
Member

wwylele commented Aug 18, 2019

Some internal testing indeed shows that disabling accurate GS doesn't help performance, and sometimes even make it worse. I am going to merge this after coordinating the server side change.

@wwylele wwylele merged commit b4d45b5 into citra-emu:master Aug 18, 2019
2 of 3 checks passed
@tywald tywald deleted the accurate-gs-on branch Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants