Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opengl: remove hw geometry shader related stuff #4894

Merged
merged 1 commit into from Sep 2, 2019

Conversation

wwylele
Copy link
Member

@wwylele wwylele commented Aug 19, 2019

Continuation of #4879, removing dead code.


This change is Reviewable

@@ -392,8 +390,7 @@ bool RasterizerOpenGL::SetupGeometryShader() {
shader_program_manager->UseFixedGeometryShader(gs_config);
return true;
} else {
PicaGSConfig gs_config(regs, Pica::g_state.gs);
return shader_program_manager->UseProgrammableGeometryShader(gs_config, Pica::g_state.gs);
LOG_ERROR(Render_OpenGL, "Accelerate draw doesn't support geometry shader");
Copy link
Member

@zhaowenlan1779 zhaowenlan1779 Aug 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be a UNREACHABLE_MSG

@purpasmart96
Copy link
Member

purpasmart96 commented Aug 25, 2019

So is all this now completely unused now?

@jroweboy
Copy link
Contributor

jroweboy commented Aug 31, 2019

@purpasmart96 this was an attempt to use host geometry shaders to implement guest geometry shaders, but it was very limited in scope, and could never work properly due to shader register preservation on the 3DS. As such, it caused issues that were undetectable in code, and only worked on a select number of titles.

@jroweboy jroweboy merged commit 8acd2b9 into citra-emu:master Sep 2, 2019
2 of 3 checks passed
@wwylele wwylele deleted the remove-gs branch Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants