Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applets/swkbd: Remove text memory clearing #5016

Merged
merged 1 commit into from Dec 1, 2019

Conversation

zhaowenlan1779
Copy link
Member

@zhaowenlan1779 zhaowenlan1779 commented Dec 1, 2019

The text shared memory wasn't supposed to be cleared according to my comparison with the LLE swkbd. This can cause issues in certain games such as Harvest Moon.

A null terminator is added to the text copied to mark the end of the string.

Fixes #4178.


This change is Reviewable

The text shared memory wasn't supposed to be cleared according to my comparison with the LLE swkbd. This can cause issues in certain games such as Harvest Moon.

A null terminator is added to the text copied to mark the end of the string.
ghost
ghost approved these changes Dec 1, 2019
wwylele
wwylele approved these changes Dec 1, 2019
@wwylele wwylele merged commit 4efb9c6 into citra-emu:master Dec 1, 2019
3 checks passed
@zhaowenlan1779 zhaowenlan1779 deleted the swkbd-fix branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants