Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interlaced stereo 3d option #5018

Merged
merged 2 commits into from Jan 18, 2020
Merged

Interlaced stereo 3d option #5018

merged 2 commits into from Jan 18, 2020

Conversation

iwubcode
Copy link
Contributor

@iwubcode iwubcode commented Dec 6, 2019

This adds support for interlaced 3d (common in passive 3d supported monitors and tv screens).

Images:

citra_interlaced_ui

citra_interlaced_game


This change is Reviewable

@jroweboy
Copy link
Contributor

jroweboy commented Dec 6, 2019

This looks awesome! For a bit of a heads up, I've got a somewhat large PR about ready to merge that'll affect this code, which might also fix your fullscreen bug. See PR #4940 for the details. Since its really close to merging, lets look to get this rebased after its merged, and then we can add this one to canary for user testing too. I was hoping to merge it today, but got side tracked on other projects ^^;

One more note: we like to have screenshots for any UI changes, so if you have a chance, can you screen shot your new menu setting (for people to know where to find it when testing) and what the expected outcome is (showing an interlaced frame from a game should be fine)!

@iwubcode
Copy link
Contributor Author

iwubcode commented Dec 6, 2019

Sounds good @jroweboy ! I'll look to add some screenshots and once the 4940 is merged, I'll rebase. Thanks!

@jroweboy
Copy link
Contributor

jroweboy commented Dec 17, 2019

For a followup, I've merged #4940, so rebase when ever you get some time pretty please :)

@iwubcode iwubcode changed the title WIP: Interlaced stereo 3d option Interlaced stereo 3d option Dec 25, 2019
@iwubcode
Copy link
Contributor Author

iwubcode commented Dec 25, 2019

@jroweboy - from what I can tell, fullscreen is now working properly. Thanks for your hard work! I've removed the WIP status

@vitor-k
Copy link
Contributor

vitor-k commented Jan 16, 2020

Shouldn't default_ini.h also get an updated description?

@iwubcode
Copy link
Contributor Author

iwubcode commented Jan 17, 2020

@vitor-k - thank you, I was not aware of that file. Updated!

@jroweboy
Copy link
Contributor

jroweboy commented Jan 18, 2020

Just tested this out, I don't have a passive 3d screen, but looks fine to me otherwise. LGTM

@jroweboy jroweboy merged commit 5fdcff9 into citra-emu:master Jan 18, 2020
3 checks passed
@iwubcode iwubcode deleted the passive-3d branch Jan 18, 2020
@FireGate13
Copy link

FireGate13 commented Apr 12, 2022

Hi , interlaced (normal or inverted) does not display normally in all games. For example in Mario Kart 7 , the image is distorted.
wrong intelacing mario kart 7
wrong intelacing mario kart 7 2

if you isolate one eye , you can see the image is distorted:
mk7 one eye

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants