Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Upright/Book-style layout #5043

Merged
merged 4 commits into from Jan 21, 2020
Merged

Conversation

vitor-k
Copy link
Contributor

@vitor-k vitor-k commented Jan 2, 2020

Some games use this orientation for some or all of the gameplay. Closes #1534.

example (game doesn't use the orientation, but I don't have one that does):
mlsss_upright_fixed3

Open to suggestions for the naming of the layouts.

Changes to configuration:
config change 2
Changes to the menu:
Menu change 3


This change is Reviewable

@vitor-k vitor-k changed the title Screen rotate Implement Upright/Book-style layout Jan 2, 2020
@vitor-k vitor-k force-pushed the screen-rotate branch 3 times, most recently from 96edbae to de664c9 Compare Jan 8, 2020
@vitor-k vitor-k force-pushed the screen-rotate branch 2 times, most recently from 4383da9 to e05e610 Compare Jan 18, 2020
src/core/frontend/framebuffer_layout.cpp Outdated Show resolved Hide resolved
vitor-k added 4 commits Jan 21, 2020
This is based on what was done using additional layouts, but modified
to have a variable to control rotation and making it so Single Screen
Layout behaves like Upright Single would, and Default Layout behaves
like Upright Double would, when the new variable is used.

Large Layout and Side Layout currently ignore the new variable.
New variable still currently doesn't have a hotkey.
@jroweboy jroweboy merged commit a0f9c79 into citra-emu:master Jan 21, 2020
0 of 3 checks passed
@vitor-k vitor-k deleted the screen-rotate branch Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants