Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port yuzu-emu/yuzu#3316: "Add headbar icon on Linux" #5061

Merged
merged 1 commit into from Jan 19, 2020

Conversation

FearlessTobi
Copy link
Contributor

@FearlessTobi FearlessTobi commented Jan 19, 2020

See yuzu-emu/yuzu#3316 for more details.

Original description:
Fixes yuzu-emu/yuzu#1898.


This change is Reviewable

@jroweboy jroweboy merged commit 3c3fcd8 into citra-emu:master Jan 19, 2020
3 checks passed
@FearlessTobi FearlessTobi deleted the port-3316 branch Jan 19, 2020
@edisionnano
Copy link

edisionnano commented Dec 31, 2020

This pull request shouldn't have been merged, it looks for the ico in ../dist/citra.ico which means there should be a folder called dist that contains citra.ico from where the binary is run from.

@Amnesia1000
Copy link
Contributor

Amnesia1000 commented Apr 2, 2021

Even if "dist/citra.png" is present, it still does not show the application icon in Linux.

I just realized that it must be in "../dist/" and also be an .ico file. But the zip provided contains a PNG file, which is also in the same folder as the binary. Could you change it to look for the file (either PNG or ICO) in the "dist/" folder and not in "../dist/"?

I myself modified the file "src/citra_qt/main.ui" from this

<property name="windowIcon">
   <iconset>
    <normaloff>../dist/citra.ico</normaloff>../dist/citra.ico</iconset>
  </property>

to this

<property name="windowIcon">
   <iconset>
    <normaloff>dist/citra.ico</normaloff>dist/citra.ico</iconset>
  </property>

It would be nice to have it like this, it is cumbersome to have to search in a folder lower than the one where the binary is located.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No icon in the headbar on Linux
6 participants