Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port yuzu-emu/yuzu#3339: "GUI: fix minor issues with dark themes + rename and reorder themes" #5077

Merged
merged 3 commits into from Feb 8, 2020

Conversation

FearlessTobi
Copy link
Contributor

@FearlessTobi FearlessTobi commented Jan 28, 2020

See yuzu-emu/yuzu#3339 for more details.

Original description:
This PR fixes few minor UI issues with dark themes also trying to mimic more "Default" ("Light") mode styling and component sizes to avoid resize on theme change. The following changes has been made:

  • mimic "Default" theme list headers styling - use list background color, border omission, no extra padding - Screenshot 1
  • decrease contrast of even rows on the lists to mimic "Default" theme styling and differentiate those rows more from Status Bar or Filter Bar - Screenshot 1
  • update tabs minimal size and padding to roughly match "Default" theme styling - Screenshot 2
  • fix Main Menu and Context Menu (ex. game row) checkbox position and items padding - Screenshot 3
  • fix ComboBox currently selected value being repositioned on options list open (only "Dark" themes seems affected) - Preview 1

I have also changed the themes names and reordered them to make it even more obvious for user how the theme will be looking like. It's completely optional change, even rather proposition, which I can ditch if you don't like it.

Currently themes list looks like:

  • Default
  • Dark
  • Colorful
  • Colorful Dark

Proposed names and order (also visible in Preview 1):

  • Light
  • Light Colorful
  • Dark
  • Dark Colorful

I'm open to any suggestions and I would like to try to fix some more themes issues if you have experienced any.

Screenshot 1

y1

Screenshot 2

y2

Screenshot 3

y3

Preview 1

yuzucb


This change is Reviewable

@FearlessTobi
Copy link
Contributor Author

FearlessTobi commented Jan 30, 2020

Any review?

Copy link
Member

@zhaowenlan1779 zhaowenlan1779 left a comment

Did not really read the stylesheet, but it looks good

@jroweboy jroweboy merged commit 03cde53 into citra-emu:master Feb 8, 2020
2 of 3 checks passed
@FearlessTobi FearlessTobi deleted the port-3339 branch Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants