service/cam: Implement Vsync interrupt events #5116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to HW tests, this vsync event is signaled for activated cameras at about the same frequency as the frame rate. The last 5 vsync timings are recorded (in microseconds) and can be retrieved with the service function. Also, corrected the default frame_rate to 15, according to HW test. This should fix the missing camera images in certain games.
zhaowenlan1779
changed the title
B3n30
approved these changes
Mar 1, 2020
Looks good. Will add it to canary, so that we can get user feedback
|
Once again, testing Style Savvy: Fashion Forward. Weirdly, going into the AR Photo mode crashes Citra the first time, but when entering it again, it works great!
While in the mode though, changing the camera photo doesn't work. |
|
@RocketRobz should be fixed now, thanks for reporting. |
|
I'm going to merge this in 24 hours if no more comments. |
This was referenced Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Hopefully fixes #3739, fixes #3794, fixes #4449.
cc @RocketRobz @SatoshiOkujun @xxx169
According to HW tests, this vsync event is signaled for activated cameras at about the same frequency as the frame rate. The last 5 vsync timings are recorded (in microseconds) and can be retrieved with the service function.
Also, corrected the default frame_rate to 15, according to HW test.
This should fix the missing camera images in certain games. Note that, SynchronizeVsyncTiming is still stubbed currently.
This change is