Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/cam: Implement Vsync interrupt events #5116

Merged
merged 2 commits into from Mar 12, 2020

Conversation

zhaowenlan1779
Copy link
Member

@zhaowenlan1779 zhaowenlan1779 commented Mar 1, 2020

Hopefully fixes #3739, fixes #3794, fixes #4449.
cc @RocketRobz @SatoshiOkujun @xxx169

According to HW tests, this vsync event is signaled for activated cameras at about the same frequency as the frame rate. The last 5 vsync timings are recorded (in microseconds) and can be retrieved with the service function.

Also, corrected the default frame_rate to 15, according to HW test.

This should fix the missing camera images in certain games. Note that, SynchronizeVsyncTiming is still stubbed currently.


This change is Reviewable

According to HW tests, this vsync event is signaled for activated cameras at about the same frequency as the frame rate. The last 5 vsync timings are recorded (in microseconds) and can be retrieved with the service function.

Also, corrected the default frame_rate to 15, according to HW test.

This should fix the missing camera images in certain games.
@zhaowenlan1779 zhaowenlan1779 changed the title service/cam: Implement Vsync interrupt callbacks service/cam: Implement Vsync interrupt events Mar 1, 2020
B3n30
B3n30 approved these changes Mar 1, 2020
Copy link
Contributor

@B3n30 B3n30 left a comment

Looks good. Will add it to canary, so that we can get user feedback

@RocketRobz
Copy link

RocketRobz commented Mar 1, 2020

Once again, testing Style Savvy: Fashion Forward.

Weirdly, going into the AR Photo mode crashes Citra the first time, but when entering it again, it works great!

Citra test

While in the mode though, changing the camera photo doesn't work.
It stays the same 'til I re-enter AR Photo mode, or change rendering/window size of the emulator.

@zhaowenlan1779
Copy link
Member Author

zhaowenlan1779 commented Mar 3, 2020

@RocketRobz should be fixed now, thanks for reporting.

@zhaowenlan1779
Copy link
Member Author

zhaowenlan1779 commented Mar 11, 2020

I'm going to merge this in 24 hours if no more comments.
If any of the linked issues turned out to be unresolved we can reopen them later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canary-merge pr:pending-merge
Projects
None yet
3 participants