service/ldr_ro: Fix CRO loading when the buffer contained multiple VM areas #5125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #4493
Fixed two bugs regarding adjacent memory areas with the same permission and state, but different backing pointers.
According to wwylele, the reason the bug in RO was made was that
citra/src/core/hle/kernel/svc.cpp
Lines 1092 to 1104 in 7afcc0d
so CRO code should contain the same merging logic or equivalent, or directly invoke the SVC implementation.
This change is