Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add program counter in unmapped memory access log messages #5149

Merged
merged 3 commits into from Apr 27, 2020
Merged

add program counter in unmapped memory access log messages #5149

merged 3 commits into from Apr 27, 2020

Conversation

badda71
Copy link
Contributor

@badda71 badda71 commented Mar 26, 2020

This will help developers track down the source for their unmapped memory read/writes. It did help me a lot already ...


This change is Reviewable

B3n30
B3n30 approved these changes Mar 28, 2020
Copy link
Contributor

@B3n30 B3n30 left a comment

Looks fine besides clang-format

@FernandoS27
Copy link
Contributor

FernandoS27 commented Apr 2, 2020

hmn I don't think dynarmic updates the PC register but until either an SVC is called or Ticks run out.

@Subv
Copy link
Member

Subv commented Apr 11, 2020

@FernandoS27 is right, this will only log the start of the JIT block, although that is plenty help still

Subv
Subv approved these changes Apr 19, 2020
Copy link
Member

@Subv Subv left a comment

@badda71 Please fix the clang-format issues so we can merge this

@badda71
Copy link
Contributor Author

badda71 commented Apr 19, 2020

Ok, fixed the clang format issues but now the linux build fails. Don't think my code is the reason though ...
collect2: fatal error: ld terminated with signal 9 [Killed]

@B3n30 B3n30 merged commit f18aef0 into citra-emu:master Apr 27, 2020
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants