Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdbstub: Fix some gdbstub jankiness #5185

Merged
merged 1 commit into from Apr 16, 2020

Conversation

merryhime
Copy link
Member

@merryhime merryhime commented Apr 6, 2020

  1. Ensure that register information available to gdbstub is most up-to-date.
  2. There's no reason to check for current_thread == thread when emitting a trap packet.
    Doing this results in random hangs whenever a step happens upon a thread switch.

Not sure whether (1) is actually necessary. I'm planning on a refactoring of the JIT which will eventually make it a moot point anyway (using contexts directly instead of needing to Load/Store them).


This change is Reviewable

1. Ensure that register information available to gdbstub is most up-to-date.
2. There's no reason to check for current_thread == thread when emitting a trap.
   Doing this results in random hangs whenever a step happens upon a thread switch.
@hamish-milne hamish-milne merged commit 9afd58c into citra-emu:master Apr 16, 2020
3 checks passed
@merryhime merryhime deleted the fix-gdbstub branch Apr 16, 2020
bunnei added a commit to yuzu-emu/yuzu that referenced this issue Apr 22, 2020
Port citra-emu/citra#5185: "gdbstub: Fix some gdbstub jankiness"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants